Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong font-family order #11037

Closed
myfonj opened this issue Jun 7, 2018 · 3 comments
Closed

Wrong font-family order #11037

myfonj opened this issue Jun 7, 2018 · 3 comments
Projects
Milestone

Comments

@myfonj
Copy link

myfonj commented Jun 7, 2018

RocketChat.theme.addPublicFont('body-font-family', '-apple-system, BlinkMacSystemFont, Roboto, \'Helvetica Neue\', Arial, sans-serif, \'Apple Color Emoji\', \'Segoe UI\', \'Segoe UI Emoji\', \'Segoe UI Symbol\', \'Meiryo UI\'');

For some (quite understandable) reason, on Windows 10 such declaration produces funky results for emoji and /or combining characters. , Arial, sans-serif should be at the end of such declaration, which should be from specific to generic font faces, here the order of Segoes is reversed and probably shadowed by the generic family.

@engelgabriel engelgabriel added this to the 0.66.0 milestone Jun 7, 2018
@engelgabriel engelgabriel added this to Desireable in June/2018 via automation Jun 7, 2018
@engelgabriel
Copy link
Member

@myfonj
Copy link
Author

myfonj commented Jun 7, 2018

Found that while messing with userstyle that disables 'picturized' emojis and returns their text content back, and during investigation found there are more quirks than expected:

https://imgur.com/a/eh8N3sg
https://codepen.io/myf/pen/WyGqbq
https://emojipedia.org/keycap-digit-two/

The outcome is that for some fonts handles some ways of encoding better and that "Segoe UI Emoji" has most probably some kind of flaw (on my machine). Resorting to "Segoe UI" alone seems to be the best solution for this certain problem, although it takes away the colours in emojis. But it is quite unrelated to RC since you are using own robust imagery :]

@myfonj
Copy link
Author

myfonj commented Jun 20, 2018

Looking at ↑ pull (https://github.com/RocketChat/Rocket.Chat/pull/11191/files#diff-39d471521e300f53e48eec47f92c0401R69) this will technically mean given version will have basic windows font changed from Arial to Segoe UI, which has different metrics and could potentially surprise users.
There's nothing wrong with it and it was basically my initial proposal (although such switch was unintentional: I just wanted to fix some obscure emoji quirks). But all things considered, giving more generic system font family before those "emoji" thingies could have been beneficial for some cases after all. I was probably overly dogmatic in the initial report…

June/2018 automation moved this from Desireable to Closed Jun 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
June/2018
  
Closed
Development

No branches or pull requests

2 participants