Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REGRESSION] Mobile apps depending on settings again to show the OAuth options #11064

Closed
rafaelks opened this issue Jun 8, 2018 · 1 comment

Comments

@rafaelks
Copy link
Contributor

rafaelks commented Jun 8, 2018

Description:

After this PR #10724, the WordPress authorization option differs based in a setting of the server. This information needs to come on the OAuth services API. The client should not need both Settings + OAuth APIs to present the OAuth options.

On mobile, we're forcing the WordPress to use this URL to authorize the user:

https://public-api.wordpress.com/oauth2/authorize

We've two options:

  1. Return the correct authorization URL to the API;
  2. Return some information on the API that allow us to choose between different URLs in the clients;
@geekgonecrazy
Copy link
Member

geekgonecrazy commented Jun 8, 2018

Can we maybe switch all oauth to use the exact same custom oauth? This way when the mobile teams call the api they will get all values needed and not have to depend on settings for some and the api for others?

By custom oauth I mean using the internal api defined here: https://github.com/RocketChat/Rocket.Chat/blob/develop/packages/rocketchat-custom-oauth/server/custom_oauth_server.js that end users use to define custom oauth. If we could either use the exact same api by all to register oauth. Or... at the very least make sure the rest endpoint returns all non-custom oauth and all values. (ie no guessing or hard coding needed ios/android side)

I think this is going to be extremely important, especially since in the future we might be moving to adding in oauth providers via Rocket.Chat Apps.

@engelgabriel engelgabriel added this to Desireable in June/2018 via automation Jun 8, 2018
@engelgabriel engelgabriel removed this from Desireable in June/2018 Jun 8, 2018
@engelgabriel engelgabriel added this to Desireable in June/2018 via automation Jun 8, 2018
@engelgabriel engelgabriel added this to the 0.66.0 milestone Jun 8, 2018
June/2018 automation moved this from Desireable to Closed Jun 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
June/2018
  
Closed
Development

No branches or pull requests

4 participants