Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RocketChat.SlackBridge.importMessages is not a function #11356

Closed
JesseVS opened this issue Jul 5, 2018 · 12 comments
Closed

RocketChat.SlackBridge.importMessages is not a function #11356

JesseVS opened this issue Jul 5, 2018 · 12 comments
Assignees
Milestone

Comments

@JesseVS
Copy link

JesseVS commented Jul 5, 2018

Description:

I have enabled the SlackBridge to sync messages between Slack and RocketChat. Normally after an upgrade of RocketChat I run /slackbridge-import in the channels I am part of. So the messages are synced back.
After the upgrade to 0.66.1 from 0.65.2 I received the following message:
SlackBridge got an error while importing your messages at <channel>: RocketChat.SlackBridge.importMessages is not a function

Steps to reproduce:

  1. Go to any channel that is synced with Slack
  2. Type /slackbridge-import
  3. Hit enter

Expected behavior:

It imports the messages from Slack that are not in RocketChat

Actual behavior:

Received the error:
SlackBridge got an error while importing your messages at <channel>: RocketChat.SlackBridge.importMessages is not a function

Server Setup Information:

  • Version of Rocket.Chat Server: 0.66.1
  • Operating System: CoreOS / Kubernetes
  • Deployment Method: Kubernetes / Docker
  • Number of Running Instances: 1
  • DB Replicaset Oplog: false
  • NodeJS Version: 8.11.3
  • MongoDB Version: 2.1.19

Additional context

Relevant logs:

Exception while invoking method 'slashCommand' TypeError: RocketChat.SlackBridge.importMessages is not a function at Object.SlackBridgeImport [as callback] (/app/bundle/programs/server/packages/rocketchat_slackbridge.js:250:28) at Object._runningSlashCommand [as run] (/app/bundle/programs/server/packages/rocketchat_lib.js:1757:55) at MethodInvocation.slashCommand (/app/bundle/programs/server/packages/rocketchat_lib.js:1812:37) at MethodInvocation.methodsMap.(anonymous function) (/app/bundle/programs/server/packages/rocketchat_lib.js:2428:36) at MethodInvocation.methodMap.(anonymous function) (packages/rocketchat_monitoring.js:2731:30) at maybeAuditArgumentChecks (/app/bundle/programs/server/packages/ddp-server.js:1877:12) at DDP._CurrentMethodInvocation.withValue (/app/bundle/programs/server/packages/ddp-server.js:902:126) at Meteor.EnvironmentVariable.EVp.withValue (packages/meteor.js:1186:12) at DDPServer._CurrentWriteFence.withValue (/app/bundle/programs/server/packages/ddp-server.js:902:98) at Meteor.EnvironmentVariable.EVp.withValue (packages/meteor.js:1186:12) at Promise (/app/bundle/programs/server/packages/ddp-server.js:902:46) at new Promise (<anonymous>:null:null) at Session.method (/app/bundle/programs/server/packages/ddp-server.js:875:23) at /app/bundle/programs/server/packages/ddp-server.js:754:85

@JesseVS
Copy link
Author

JesseVS commented Aug 13, 2018

Still in version 0.68.4

@JulioC
Copy link

JulioC commented Oct 10, 2018

Also affects 0.69.2

@kevin-og
Copy link

Same behavior in 0.70.4

@lazyants
Copy link

+1

@nylen
Copy link

nylen commented Dec 1, 2018

Still an issue in 0.71.1

@esolitos
Copy link

I can confirm, still happening on: 0.72.3

@JesseVS
Copy link
Author

JesseVS commented Dec 20, 2018

@geekgonecrazy is this on your radar?

@geekgonecrazy
Copy link
Member

Not mine specifically.. I don’t do much with importers.

@Hudell maybe on yours?

@Hudell Hudell self-assigned this Dec 21, 2018
@vwbusguy
Copy link

vwbusguy commented Feb 8, 2019

Still an issue on 0.74.2

@esolitos
Copy link

Anything we can help with?

I see that the call is against SlackBridge, however the methoid importMessages is implemented on the Adapter.

Just a wild guess, could be the fix as easy as that? :)

@geekgonecrazy
Copy link
Member

We take PRs! :) it definitely could be as easy as that.

@rodrigok
Copy link
Member

Closed via #14273

@engelgabriel engelgabriel added this to the 1.0.0 milestone Apr 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.