Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discussions: close a discussion #13664

Open
mrsimpson opened this issue Mar 11, 2019 · 8 comments
Open

Discussions: close a discussion #13664

mrsimpson opened this issue Mar 11, 2019 · 8 comments
Assignees
Labels
Milestone

Comments

@mrsimpson
Copy link
Collaborator

mrsimpson commented Mar 11, 2019

Motivation

Usually, a discussion is being created to discuss something with a goal. Once this goal has been achieved, the discussion is going to be deserted. Semantically, it's "done".

Proposal

The same semantic already exists for a room: "Archived". Once a room is archived, it can still be read, but subscriptions are hidden (so that the side panel is getting cleaned up) and the room is write-protected.
The "archiving" function could be re-used, it just needs to be made more prominent. A dedicated button either next to the message area or in the room properties (maybe even replacing leave/hide) would help.
In addition to that, the status "closed" should be visualized on the discussion-started-message in the parent room.

@engelgabriel
Copy link
Member

#13843

@engelgabriel engelgabriel added this to the 1.0.0 milestone Mar 21, 2019
@engelgabriel engelgabriel changed the title Threading: close a thread Discussions: close a discussion Mar 21, 2019
@engelgabriel
Copy link
Member

#13644

@engelgabriel engelgabriel modified the milestones: 1.0.0, 1.1.0 Apr 6, 2019
@ChrissW-R1
Copy link
Contributor

It would also be nice to have a permission to allow users to leave discussion, but not public channels or private groups!

@rodrigok rodrigok added this to Issues in 1.1.0 Review May 10, 2019
@engelgabriel engelgabriel modified the milestones: 1.1.0, 1.3.0 Jul 10, 2019
@sampaiodiego sampaiodiego modified the milestones: 1.3.0, 1.4.0 Jul 25, 2019
@engelgabriel engelgabriel modified the milestones: 2.0.0, 2.2.0 Oct 13, 2019
@engelgabriel engelgabriel modified the milestones: 2.2.0, 4.1.0 Mar 17, 2020
@softwaredoug
Copy link

It'd be great also to be able to turn a Discussion into a room or private group

@charliehelmijr
Copy link

Is this something that will be implemented?

@workdojos
Copy link

workdojos commented May 19, 2021

Checking in again, wondering how I can keep a tidy left sidebar (by deleting Discussions that are no longer being discussed). This is a borderline dealbreaker for our use case if the user can't get rid of Discussions. Are Discussions designed to live forever unless an Admin goes and deletes them?

Will the left sidebar continue to fill up with new Discussions (most dead Discussions don't have a new owner to assign), and is the whole app designed to encourage users to have an endless stream of stuff, only focusing on unread at the top, and not worrying about loads of stuff filling up the bottom like dead Discussions? Thanks

@workdojos
Copy link

workdojos commented Jun 4, 2021

Also posted here, glad to remove one or the other: #13689

@ntextreme3
Copy link

Being able to "close" a discussion I think would make it a nice choice for PR review integration. Ex: A new PR starts a discussion. Within the review, you might talk about things and there might be some things that thread out, but is part of the same discussion. Ultimately, the discussion get closed when the PR gets closed.

In integrations/slack#660 the request is for PR comments to go into a slack thread. Seems like rocket chat's "discussion" would be able to provide a better workflow, assuming the discussion eventually ends.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
1.1.0 Review
  
Issues
Development

No branches or pull requests

9 participants