Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Custom avatar on integrations not respected #14190

Closed
bkraul opened this issue Apr 18, 2019 · 2 comments
Closed

[BUG] Custom avatar on integrations not respected #14190

bkraul opened this issue Apr 18, 2019 · 2 comments

Comments

@bkraul
Copy link

bkraul commented Apr 18, 2019

Description:

Incoming hook integrations are not using the specified custom avatar for posting of messages, and are instead using the default rocket.cat avatar. This issue is related to #14038 which seems to have been already corrected.

Steps to reproduce:

  1. Deploy latest docker develop image.
  2. Create an incoming webhook integration. Set a custom avatar in place of the default.
  3. Trigger the webhook.
  4. See that the custom avatar is being ignored.

Expected behavior:

The specified avatar should be used, which was the original behavior.

Actual behavior:

Rocket.cat avatar shows up.

Rocket.Chat

Version 1.0.0-develop
Apps Engine Version 1.4.2
Database Migration 141
Database Migration Date Thu Apr 18 2019 05:53:51 GMT-0500 (Central Daylight Time)
Installed at Mon Jan 29 2018 16:02:11 GMT-0600 (Central Standard Time)
Uptime 8 hours, 48 seconds
Deployment ID JAELT9iyADPbKEGbG
PID 1
Running Instances 1
OpLog Enabled

Commit

Hash 4d160bf
Date Wed Apr 17 18:29:59 2019 -0300
Branch develop
Tag 0.74.2
Author Pierre H. Lehnen
Subject Auto remove SAML certificate header and footer (#14179)
@d-gubert
Copy link
Member

Hi @bkraul! I believe this issue has been fixed by this PR, so it should be available on the next RC.

Thanks for contributing and please reopen the issue if this problem is not solved :)

@bkraul
Copy link
Author

bkraul commented Apr 18, 2019

@d-gubert You are correct. This appears solved in the latest develop build based on commit ea58137 . Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants