Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create discussion dialog allows to query users outside of parent room #14931

Closed
ggruber4711 opened this issue Jul 4, 2019 · 3 comments
Closed

Comments

@ggruber4711
Copy link

ggruber4711 commented Jul 4, 2019

Description:

When trying to setup a multi-org Rocket.Chat instance using permission-removal of view-outside-room it correctly hides users when trying to search for them in the groups.
When you however add a new discussion to an existing group, it will allow you to invite users outside of the parent group.

Steps to reproduce:

  1. Remove permissions these permissions from role User
    • view-outside-room
    • view-c-room
    • create-c
    • create-p
  2. Create users A1 and A2 and put them into private group A-General
  3. Create users B1 and B2 and put them into new private group B-General
  4. Login with user A1
  5. Start a discussion in group A-General
  6. Start typing to invite users

Expected behavior:

Only users A1 and A2 can be seen

Actual behavior:

All users can be queried (including B1 and B2)

image

Server Setup Information:

  • Version of Rocket.Chat Server: 1.1.3
  • Operating System: Linux
  • Deployment Method: Docker
  • Number of Running Instances: 1
  • NodeJS Version: 8.11.4
  • MongoDB Version: 4.0.10
@ggruber4711
Copy link
Author

ggruber4711 commented Aug 21, 2019

Seems to be duplicate of #15212 and #14382

@ggazzo
Copy link
Member

ggazzo commented Aug 21, 2019

actually @ggruber4711 it is duplicated, please test again (2.0.0) any problem let me know

@ggazzo ggazzo closed this as completed Aug 21, 2019
@ggruber4711
Copy link
Author

I can confirm that this problem is now solved with 2.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants