Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interface shows only 50 custom emoji #15118

Closed
mide opened this issue Aug 6, 2019 · 10 comments
Closed

Interface shows only 50 custom emoji #15118

mide opened this issue Aug 6, 2019 · 10 comments
Labels
duplicate Closed as Duplicate

Comments

@mide
Copy link
Contributor

mide commented Aug 6, 2019

Description:

When a Rocket.Chat installation has more than 50 custom emoji, only the first 50 show with no pagination buttons. Additionally, the search only searches those visible and not the whole set.

Steps to reproduce:

  1. Go to administration console
  2. Click "custom emoj"
  3. Add at least 51 emoji. Ideally with names over the spectrum of the alphabet
  4. Reload the page, you should not see all emoji.
  5. If you search for an emoji towards the end of the alphabetically sorted list you added, it will not appear.

Expected behavior:

I expect to see all emoji or pagination buttons

Actual behavior:

No pagination buttons, and results capped at 50.

Screen Shot 2019-08-06 at 6 00 45 PM

Server Setup Information:

  • Version of Rocket.Chat Server: 1.2.1
  • Operating System: Amazon Linux (Running official Docker Image)
  • Deployment Method: Docker
  • Number of Running Instances: 1
  • DB Replicaset Oplog:
  • NodeJS Version: v8.11.4
  • MongoDB Version: 4.0.10

Additional context

Relevant logs:

@lorek123
Copy link

lorek123 commented Aug 7, 2019

seems to be fixed in 1.3.0

@mide
Copy link
Contributor Author

mide commented Aug 7, 2019

I still see this behavior, now upgraded to 1.3.0.

@lorek123
Copy link

lorek123 commented Aug 7, 2019

#15119 maybe this will actually fix this ;)

@reetp
Copy link

reetp commented Aug 7, 2019

@rocket-cat label add duplicate

Duplicate of:
#14743

Please follow this before opening an Issue:
https://rocket.chat/docs/contributing/reporting-issues

Always test on latest (and you really should not be on 1.2.1 if you check releases.....) and search thoroughly for existing issues

e.g.
https://github.com/RocketChat/Rocket.Chat/issues?utf8=%E2%9C%93&q=is%3Aissue+emoji+50

@rocket-cat rocket-cat bot added the duplicate Closed as Duplicate label Aug 7, 2019
@reetp
Copy link

reetp commented Aug 7, 2019

@rocket-cat close

@rocket-cat rocket-cat bot closed this as completed Aug 7, 2019
@mide
Copy link
Contributor Author

mide commented Aug 7, 2019

I agree I should have tested on latest, shame on me for that.

But the issue I "duplicated" was closed a month ago (#14743), and the PR with the fix (#15119) was opened ten minutes AFTER I opened this issue. So when I filed, I felt it was still an active issue.

@reetp
Copy link

reetp commented Aug 7, 2019

Sorry - this is not my day job... I just try and help as my contribution back to open source.... I just try and clear duplicates and 'support' Issues so the devs can concentrate on the problematic ones.

I don't check the times on stuff - just do a search for a few key words.

I'm not quite sure what they did with this as there seems to be a a couple PRs etc. Simple answer is that there was a bug there so just follow up on the existing bug rather than create a new one.

I think if you look 14951 was the original fix to 14743 and that was amended by 15119.

That is in Develop and should be out with 1.4.x - you can do yourself a test build and see if it works (and please update to at least 1.2.3 for your own security.... !!!!!)

@mide
Copy link
Contributor Author

mide commented Aug 7, 2019

Thanks for the reply @reetp - It's people like you who make the open source world go 'round. I do appreciate the efforts made to reduce duplicates.

I have updated to 1.3.0 - Thanks for the heads up :)

@ghost
Copy link

ghost commented Aug 9, 2019

@reetp @mide I can confirm that this issue has been fixed in v1.3.1 which includes the PR #15119.

@mide
Copy link
Contributor Author

mide commented Aug 9, 2019

Thanks for following up, I will be upgrading shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate Closed as Duplicate
Projects
None yet
Development

No branches or pull requests

3 participants