Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quotes not being shown in group chats (E2E) #16148

Open
stukev opened this issue Jan 7, 2020 · 2 comments · Fixed by #26303
Open

Quotes not being shown in group chats (E2E) #16148

stukev opened this issue Jan 7, 2020 · 2 comments · Fixed by #26303
Labels
feat: e2e stat: stale Stale issues will be automatically closed if no activity ui/ux

Comments

@stukev
Copy link

stukev commented Jan 7, 2020

Description:

Whenever anyone in our group chats uses the quote functionality to quote someone else's message it only displays the actual answer typed by the user, not the original quote. Tested in web client as well as the desktop client for Ubuntu. I noticed on Ubuntu that I see the formatting for the quote appear in the desktop notification, which makes me think it's a render issue rather than a more complicated bug.

Steps to reproduce:

  1. Create a group chat (we use E2E)
  2. Add multiple people to the conversation.
  3. Use the quote button to quote what someone else said.
  4. Add some text underneath the quote and send the message: https://i.imgur.com/t2lR8bT.png
  5. Only what you typed will be shown in the group chat, the quote is missing: https://i.imgur.com/mt2Qi8S.png

Expected behavior:

I expect the quote to be shown the same way it does in 1:1 conversation with a user directly. It works without any problems there.

Actual behavior:

Only what you typed will be shown in the group chat, the quote is missing: https://i.imgur.com/mt2Qi8S.png

Server Setup Information:

  • Version of Rocket.Chat Server: 2.3.1
  • Operating System: Ubuntu 19.04
  • Deployment Method: tar
  • Number of Running Instances: 1
  • DB Replicaset Oplog: Enabled
  • NodeJS Version: v8.15.1
  • MongoDB Version: 3.6.14

Client Setup Information

  • Desktop App or Browser Version: Tested with latest Firefox, Opera, Chrome, bug is replicable on all versions.
  • Operating System: Windows, Linux and Android

Additional context

As noted above, on Ubuntu I can see Desktop notifications when somebody tried to send a quoted message to group chat, I can see the markup in the notification but it doesn't get rendered in the chat itself.

@github-actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stat: stale Stale issues will be automatically closed if no activity label Jul 16, 2020
@no-nice-username
Copy link

Bump for the thread. The issue still exists, but is closed for no reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat: e2e stat: stale Stale issues will be automatically closed if no activity ui/ux
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants