Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add message editting timeout to preserve old messages #1796

Closed
fduraibi opened this issue Jan 2, 2016 · 3 comments
Closed

Add message editting timeout to preserve old messages #1796

fduraibi opened this issue Jan 2, 2016 · 3 comments

Comments

@fduraibi
Copy link
Contributor

fduraibi commented Jan 2, 2016

Editing previous messages is great specially to correct spelling mistakes, however, after a certain time it becomes useless or undesirable. (it can also be used to make fun of someone :) )

Me: Would you like a free coffee?
Victim: Sure I would love that.

Sometime later:

Me: Would you like to hack and destroy Rocket Chat?    *Edited by me 
Victim: Sure I would love that.

This is just an example, and someone can argue that the victim can also see the change, but it won't be easy if those lines are few pages away from the current page. Since no one gets notifications about edits.
Also editing something old is not useful and most people who have read the old message will not see the change, while they will see the change if the writer wrote the corrected version again.

That can be mitigated with a timeout timer that can be set by the admin at the server level, or maybe room level.
Very active rooms may need a short timeout, while other rooms might need to allow edits all the time to update e.g. project progress/ updates ...etc

@Megatronic79
Copy link

+1 also falls into QA and compliance when discussions between clients should be kept for legal and compliance reasons and should not be ableto be edited - compliment the proposed auditing and logs and can possibly be merged with

#795
#752
#722

@k0nsl
Copy link
Contributor

k0nsl commented Jan 3, 2016

isn't this already available through Block Message Editing After (n) Minutes, or did I misunderstand you?

@fduraibi
Copy link
Contributor Author

fduraibi commented Jan 3, 2016

@k0nsl 👍

Shame on me hahaha

@fduraibi fduraibi closed this as completed Jan 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants