Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search mark breaks links #18696

Closed
ghost opened this issue Aug 27, 2020 · 2 comments
Closed

Search mark breaks links #18696

ghost opened this issue Aug 27, 2020 · 2 comments

Comments

@ghost
Copy link

ghost commented Aug 27, 2020

Description:

Links in search results are broken because <mark> is inserted to highlight the search key.

Highlighting is great, a broken link isn't

Steps to reproduce:

  1. send link test.com
  2. search "test"
  3. click link in search result

Expected behavior:

http://test.com

Actual behavior:

http://<mark>test</mark>.com

image

only the link text should include <mark>, not href

Server Setup Information:

  • Version of Rocket.Chat Server: 3.5.2
  • Operating System:
  • Deployment Method:
  • Number of Running Instances:
  • DB Replicaset Oplog:
  • NodeJS Version:
  • MongoDB Version:

Client Setup Information

  • Desktop App or Browser Version: Browser
  • Operating System:

Additional context

Relevant logs:

cc #16166

@TBG-FR
Copy link
Contributor

TBG-FR commented Aug 28, 2020

Duplicate of #18456

@MartinSchoeler
Copy link
Contributor

Please move this discussion to #18770 Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants