Admin can't change its own username when 'Allow Username Change' is disabled

[Angstroem]

Description:

When trying to change your own username as an administrator, with the option Allow Username Change is disabled, an error pops up saying this action is not allowed. But changing other usernames (including other administrator's usernames) works just fine.

Steps to reproduce:

1. Be in the Admin group
2. Turn off: Accounts -> Allow Username Change
3. Select yourself in the Users tab and click on Edit
4. Edit your username to a different one and click on Save

Expected behavior:

As an administrator it should always be possible to change its own name or the name of others, regardless of the Allow Username Change option.

Actual behavior:

The own username cannot be changed. Yielding to this error message:

Changing the username of another admin user is possible, as expected.

Server Setup Information:

• Version of Rocket.Chat Server: 3.14.1
• Operating System: Linux Debian
• Deployment Method: tar
• Number of Running Instances: 1
• DB Replicaset Oplog: n.a.
• NodeJS Version: v12.22.1
• MongoDB Version: 4.0.23

Client Setup Information

• Desktop App or Browser Version: Desktop App, Version 3.1.1
• Operating System: Windows 10

Additional context

n.a.

Relevant logs:

n.a.

[johncrisp]

Hi and thanks for reporting this.

I am sure there will be some reasoning behind this but we'll need the devs to have a look.

There was probably a reason for doing it but I am not sure of the logic.

[Angstroem]

I reported it because it was unexpected behavior in my mind. In my deployment i don't want the users to change their own username because all names should follow a specific naming convention. But i as an administrator should certainly be able to change all user's names if needed, including my own username.

But thats just my point of view, maybe there is another reason behind it being this way.