Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown code block not interpreted as link text in 3.15.0 #22262

Open
theBrash opened this issue Jun 7, 2021 · 4 comments
Open

Markdown code block not interpreted as link text in 3.15.0 #22262

theBrash opened this issue Jun 7, 2021 · 4 comments

Comments

@theBrash
Copy link

theBrash commented Jun 7, 2021

Description:

Steps to reproduce:

  1. Update to RocketChat Version 3.15.0
  2. Send a message with the following content or look for messages, that use this format :
    [```this is a code block that should also be used as a link```](http://www.thisisadomain.tld)

Expected behavior:

In the previous RocketChat versions the code block was a link. The actual link was hidden.
In GitHub it also works:
this is a code block that should also be used as a link

Actual behavior:

image
The code block isn't interpreted as the link text anymore.

Server Setup Information:

  • Version of Rocket.Chat Server: 3.15.0
  • Operating System: Debian 10.9
  • Deployment Method: docker
  • Number of Running Instances: 1
  • DB Replicaset Oplog: ?
  • NodeJS Version: v12.22.1
  • MongoDB Version: 4.0

Client Setup Information

  • Desktop App: 3.2.2
  • Browser Version: Opera 76.0.4017.177
  • Operating System: Pop!_OS 20.04 LTS

Additional context

Relevant logs:

Browser Log:

/api/ecdh_proxy/initEncryptedSession:1 Failed to load resource: the server responded with a status of 404 ()
/node_modules/@rocket.chat/ui-kit/dist/index.js:1 ui-kit version: 0.26.0
/node_modules/@rocket.chat/fuselage-ui-kit/dist/fuselage-ui-kit.production.js:1 fuselage-ui-kit version: 0.26.0
Henning:1 Failed to load resource: the server responded with a status of 404 ()

Server Log:

(node:8) [DEP0131] DeprecationWarning: The legacy HTTP parser is deprecated.
LocalStore: store created at 
LocalStore: store created at 
LocalStore: store created at 
Setting default file store to GridFS
{"line":"120","file":"migrations.js","message":"Migrations: Migrating from version 222 -> 225","time":{"$date":1622817733011},"level":"info"}
{"line":"120","file":"migrations.js","message":"Migrations: Running up() on version 223","time":{"$date":1622817733012},"level":"info"}
{"line":"120","file":"migrations.js","message":"Migrations: Running up() on version 224","time":{"$date":1622817733015},"level":"info"}
{"line":"120","file":"migrations.js","message":"Migrations: Running up() on version 225","time":{"$date":1622817733019},"level":"info"}
{"line":"120","file":"migrations.js","message":"Migrations: Finished migrating.","time":{"$date":1622817733051},"level":"info"}
Not migrating, control is locked. Attempt 1/30. Trying again in 10 seconds.
{"line":"120","file":"migrations.js","message":"Migrations: Not migrating, already at version 225","time":{"$date":1622817743062},"level":"info"}
ufs: temp directory created at "/tmp/ufs"
Loaded the Apps Framework and loaded a total of 0 Apps!
Using GridFS for custom sounds storage
Using GridFS for custom emoji storage
Updating process.env.MAIL_URL
➔ System ➔ startup
➔ +---------------------------------------------------------------+
➔ |                         SERVER RUNNING                        |
➔ +---------------------------------------------------------------+
➔ |                                                               |
➔ |  Rocket.Chat Version: 3.15.0                                  |
➔ |       NodeJS Version: 12.22.1 - x64                           |
➔ |      MongoDB Version: 4.0.24                                  |
➔ |       MongoDB Engine: mmapv1                                  |
➔ |             Platform: linux                                   |
➔ |         Process Port: 3000                                    |
➔ |             Site URL: https://**********/rocketchat/          |
➔ |     ReplicaSet OpLog: Enabled                                 |
➔ |          Commit Hash: 55457025d6                              |
➔ |        Commit Branch: HEAD                                    |
➔ |                                                               |
➔ +---------------------------------------------------------------+
(node:8) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.
@johncrisp
Copy link

On open.rocket.chat earlier

Screenshot_2021-06-07_17-50-12

@johncrisp
Copy link

Please test on open.rocket.chat
Seems to be fixed.

@theBrash
Copy link
Author

theBrash commented Jun 8, 2021

I responded to your message on open.rocket.chat. For me it still doesn't work. But your message in the quote is working.
Your message from yesterday:
image
My reply, which doesn't work, but your message in the quote now looks right:
image

@theBrash
Copy link
Author

theBrash commented Jul 7, 2021

The issue still persist. To make this problem a little bit more clear, I have another example.
This is a screenshot of our Problem with the sensitive stuff blurred.
The special part of this is the second code block, which serves as a comment to the first code block.
image

As you can see, in this example some more stuff comes to light. Like the part " target="_blank" rel="noopener noreferrer">.... which seems to be some internal rocketchat stuff. That part is definitely not in the original message.
Starting with the second code block the text is also a link, which points to the desired URL. If I click on that link the site will be opened within the electron app, not in a separate browser!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants