-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CAS Plugin: Upgrade cas libs to support CAS 2.0 protocol #2325
Comments
One possible candidate which provides CAS 2.0: https://github.com/joshchan/node-cas |
Another probably better candidate would be https://www.npmjs.com/package/xcas |
Tried to use official npmjs modules to provide a CAS 2.0 library - but I failed to find a sane packaged version. Instead I tried to pull in some github module by adding it as local files, but it seems that Meteor doesnt support this practice, yet. I'm not aware of a workaround. A heads up from @Sing-Li was given to wait till RC switched to Meteor 1.3: |
Upgraded my test instance to latest develop state and tried using meteor 1.4 features such as Meteor | Npm.depends and npmjs package definitions Versions: Tried using the new package imports as described above: This fails with: @Sing-Li Any idea why this fails? |
@CoreCache Meteor 1.4 supports npm modules directly now. Please see https://guide.meteor.com/using-npm-packages.html Basically, you can just |
@RocketChat/core Are we starting to create new package as npm packages now? Are we migrating? |
@rodrigok can you help @CoreCache here? |
I'll take a look after the 0.40 release |
@CoreCache please try using this syntax:
|
That seems to work. Edit: I want to edit/develop locally before always pushing/fetching from a github repo for local testing Edit2: Using |
@CoreCache do you need our help? |
I'm on a good track now - got early CAS 2.0 response working, but it broke 1.0 ... priceless. I'm on it. |
BugFix got merged: joshchan/node-cas@4ae9f7a |
The current CAS plugin supports only CAS 1.0 which is sufficient to login with a username.
The CAS 2.0 protocol transports user attributes such as Common Name, Email, and even custom attributes. The minimal implementation for CAS 2.0 rocketchat plugin would allow defining a map of attributes, which are parsed from the CAS response and will be mapped towards what RC user attributes:
The text was updated successfully, but these errors were encountered: