Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embedded layout disappers after most redirects #23743

Open
julienchabanon opened this issue Nov 17, 2021 · 0 comments
Open

Embedded layout disappers after most redirects #23743

julienchabanon opened this issue Nov 17, 2021 · 0 comments

Comments

@julienchabanon
Copy link

julienchabanon commented Nov 17, 2021

Description:

When I load a channel with ?layout=embedded, the channel loads with the simplistic optic. This works but most button and things you can click in the interface will redirect to an URL without ?layout=embedded and so, it leaves the embedded mode.

This is the biggest issue we have so far with integrating rocketchat with our plateform. The upgrade to 4.X did not improve on this.
This is a big deal for us as we are integrating rocketchat in a multi tenant plateform meaning that, as soon as it leaves the embedded mode, client A can see users and conversations from other clients.

Steps to reproduce:

Example 1:

Open https://open.rocket.chat/channel/general?layout=embedded
Click on a user icon
Click on "View full profile"

Expected behavior:
The view stays in layout=embedded while openning the profile of the user.
Note that if you manually adds the parameter layout=embedded while the profile is open like so: https://open.rocket.chat/channel/general/members-list/user?layout=embedded, then it works. It appears to be just a matter of redirect.

Actual behavior:
The embedded disappears and the full layout loads

Example 2:

Open https://open.rocket.chat/channel/general/uploaded-files-list?layout=embedded
Click on the close arrow button on the top right side of the right sidebar

Expected behavior:
The view stays in layout=embedded while closing the right side bar.

Actual behavior:
The embedded disappears and the full layout loads

Version of Rocket.Chat Server: 4.1.0 and 3.8.x
Operating System: ...
Deployment Method: ...
Number of Running Instances: ...
DB Replicaset Oplog: ...
NodeJS Version: ...
MongoDB Version: ...
Client Setup Information
Desktop App or Browser Version: any version
Operating System: Linux Manjaro

@julienchabanon julienchabanon changed the title Embedded layout disappers after most actions Embedded layout disappers after most redirects Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant