4.4.2: GitLab OAuth doesn't work anymore

[v1adislav]

Description:

After upgrading Rocket.Chat to version 4.4.2, OAuth no longer works with GitLab.
You get an undefined error after successful login to our self-managed GitLab instance.

Steps to reproduce:

1. Upgrade Rocket.Chat to version 4.4.2
2. Click login with GitLab OAuth
3. Login into GitLab instance
4. Undefined error triggered -> Login failed

Actual behavior:

When I try to login I get "Internal server error"

Server Setup Information:

• Version of Rocket.Chat Server: 4.4.2
• Operating System: Oracle Linux 7
• Deployment Method: docker
• Number of Running Instances: 1
• DB Replicaset Oplog: yes
• NodeJS Version: v14.18.2
• MongoDB Version: 5.0.5 / wiredTiger

Client Setup Information

• Desktop App or Browser Version: Chrome
• Operating System: MacOS / Windows

Additional context

The GitLab-URL is set to our self hosted GitLab instance.

Relevant logs:

Exception while invoking method 'login' Error: Failed to complete OAuth handshake with gitlab at https://gitlab.com/oauth/token. failed [401] {"error":"invalid_client","error_description":"Client authentication failed due to unknown client, no client authentication included, or unsupported authentication method

[xcore89]

I have the same problem on version 4.4.2.

[4nt0h4]

I confirm that OAuth authorization does not work

[dudanogueira]

Hi! What are the versions you upgraded from?

this is probably related to #24355

[v1adislav]

@dudanogueira The bug started with version 4.2.2. Now I have updated from 4.4.0. How can i recover Oauth with gitlab

[ankit-jha1210]

Can I work on this issue

[ankit-jha1210]

@v1adislav can I work on this

[NeXT405]

Any news on this??

[g5pw]

I also have an Internal Server Error during OAuth login with Github after upgrading, I can see the following in the logs:

rocket-chat_rocketchat.1.8wy3ziw1gily@docker    | {"level":40,"time":"2022-02-14T16:26:33.799Z","pid":8,"hostname":"2750394edd44","name":"","name":"System","msg":"Automatically added ?close to 'redirect_uri' for github, this behavior will be removed in v5.0.0.\nPlease update your OAuth config to accept both with and without ?close as the 'redirect_uri'."}
rocket-chat_rocketchat.1.8wy3ziw1gily@docker    | Exception while invoking method 'login' TypeError: emails.find is not a function
rocket-chat_rocketchat.1.8wy3ziw1gily@docker    |     at Object.handleOauthRequest (packages/github-oauth/github_server.js:10:31)
rocket-chat_rocketchat.1.8wy3ziw1gily@docker    |     at OAuth._requestHandlers.<computed> (packages/oauth2/oauth2_server.js:10:33)
rocket-chat_rocketchat.1.8wy3ziw1gily@docker    |     at middleware (packages/oauth/oauth_server.js:171:5)
rocket-chat_rocketchat.1.8wy3ziw1gily@docker    |     at /app/bundle/programs/server/npm/node_modules/meteor/promise/node_modules/meteor-promise/fiber_pool.js:43:40

[v1adislav]

@sampaiodiego mb fix this problem?

[chriz-uniba]

I guess this is also related to #23613 --- which has some workaround that worked for us.

[cooljeanius]

This is breaking the MacPorts Rocket.Chat instance: https://lists.macports.org/pipermail/macports-users/2022-March/050863.html

[v1adislav]

problem resolve in version 4.5.2

[cooljeanius]

problem resolve in version 4.5.2

But the MacPorts Rocket.Chat instance is still broken, though...

Edit: downstream issue: https://trac.macports.org/ticket/65937