Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Short URL not recognized and converted to emoji #26475

Closed
grthr opened this issue Aug 4, 2022 · 9 comments
Closed

Short URL not recognized and converted to emoji #26475

grthr opened this issue Aug 4, 2022 · 9 comments

Comments

@grthr
Copy link

grthr commented Aug 4, 2022

Description:
When pasting an short URL like https://g.co/meet/something, it is not rendered as Link and not clickable.
Even using it inside Markdown Link style does not work.

image

Steps to reproduce:
Type https://g.co/meet/something in the message input
Expected behavior:
A link should be created to the given URL

Actual behavior:
An emoji is rendered from the :/ and no link is created.

Server Setup Information:
Version of Rocket.Chat Server: 5.0.1
Deployment Method: docker
Number of Running Instances: 1
MongoDB Version: 4.2
Client Setup Information
Desktop App or Browser Version: Electron / Web (Chrome)
Operating System: Windows

@grthr
Copy link
Author

grthr commented Aug 4, 2022

This was working fine in 4.8.1

@Akkowicz
Copy link

Akkowicz commented Aug 8, 2022

Facing the same issue, it's quite annoying.

@fuchsundvogel
Copy link

Super annoying. We had to downgrade the server to an older version because we could not send file paths anymore without them getting destroyed by emojis.

@grthr
Copy link
Author

grthr commented Aug 12, 2022

Just found out that the behavior is different in Threads. There it works as expected. Maybe this helps finding the cause of the issue.

@saschafoerster
Copy link

Bildschirmfoto 2022-08-15 um 09 14 50

Same issue with "10:30" > 0:3 get's translated into an emoji.

@Vaarlion
Copy link

Vaarlion commented Aug 17, 2022

hi :)
We just updated to the latest version, and sure thing short url aren't translated to URL.
Our autolinker regex parser is the default (://|www\.).+ so nothing there...
It look like it only fail for 1 letter subdomain ?
I have a https://s.companyname.org for short link for example, don't work
same for www.s.companyname.org
but https://s1.companyname.org do work
what is even weirder is that something like www.word.a.domain.com will link like this www.word.a.domain.com

Somewhere, there is something that break for single char in url...

:+1: is also broken, no longer returning a 👍 but :+1:
i wonder if we shouldn't just change the markdown engine ...

@Vaarlion
Copy link

Vaarlion commented Aug 22, 2022

So, in Settings, Account, Default User Preferences, you have a global switch to revert to the old message template.
image

You can also do this for your user only in My account, Preferences , Global

It does not fix this bug, but allow to work around it until the dev have the time to do so

@kekefreedog
Copy link

Same problem for me with url which doesn't have .com or dot something...
image

@hugocostadev
Copy link
Contributor

Fixed by: https://github.com/RocketChat/fuselage/pull/800/files

@hugocostadev hugocostadev moved this from To do to Close in Message Parser Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

No branches or pull requests

8 participants