Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/me slashcommand is no longer working with legacy message parser #26927

Open
chotaire opened this issue Sep 22, 2022 · 1 comment
Open

/me slashcommand is no longer working with legacy message parser #26927

chotaire opened this issue Sep 22, 2022 · 1 comment

Comments

@chotaire
Copy link

chotaire commented Sep 22, 2022

Description:

The /me slashcommand is no longer working with legacy message parser. Instead it shows a message with prepending "_ " and appending "_" characters.

Steps to reproduce:

  1. Send message /me is testing.

Expected behavior:

It should display a so-called action:

414b6650a25ed0a11d51a397a40c0ab1

Actual behavior:

Instead it shows a message with prepending "_ " and appending "_" characters.

6420a20d87eb262a7db3ac7790573573

Problem:

⚠️ The space behind the underscore "_ " at the beginning of the message is breaking it. If I edit and fix that message, it will show correctly. Doing str.substring(1) for params in Rocket.Chat/apps/meteor/app/slashcommands-me/server/me.ts might be all that's needed.

Temporary workaround for users:

When trying to send an action, don't use the /me slashcommand but type it in the correct format to be parsed. No spaces before/after the underscores: _me is testing._
We learn that in Rocket.Chat an action is nothing other than a normal message written in italic.

Server Setup Information:

  • Version of Rocket.Chat Server: 5.1.2
  • Operating System: Linux
  • Deployment Method: Docker
  • Number of Running Instances: 1 on this server
  • DB Replicaset Oplog: Unknown
  • NodeJS Version: v14.19.3
  • MongoDB Version: 5.0.12 / wiredTiger (oplog activated)

Client Setup Information

  • Desktop App or Browser Version: Chrome 105.0.5195.127
  • Operating System: Windows 11 Pro (Version 10.0.22000.1042)
@chotaire chotaire changed the title /me action is no longer working in v5.1 /me slashcommand is no longer working in v5.1 Sep 22, 2022
@dudanogueira
Copy link
Contributor

Hi! Thanks for pointing it out!

/me will not work if you have the legacy message template turned on in My Account > Preferences > Global

For the new message template it's working as expected.

This will probably not get fixed, as this module is being deprecated.

@chotaire chotaire changed the title /me slashcommand is no longer working in v5.1 /me slashcommand is no longer working with legacy message parser Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants