file sharing being opened in the same "tab" and not in a new tab (even with target _black)

[avelino]

Description:

when uploading a file (in this example pdf) and clicking on the download link it opens in the same tab

Steps to reproduce:

1. upload .pdf to channel
2. click in download (on the link with file name)

Expected behavior:

open in a new tab, not "locking" the app or tab to the file (having to close it using the browser's back button)

Actual behavior:

Server Setup Information:

• Version of Rocket.Chat Server: 6.0.1
• Operating System: Linux
• Deployment Method: docker
• Number of Running Instances: 1
• DB Replicaset Oplog:
• NodeJS Version: v14.21.2
• MongoDB Version: 4.4.15

Client Setup Information

• Desktop App or Browser Version: Brave (the same thing happens in the app)
• Operating System: macOS

Additional context

Screen.Recording.2023-04-18.at.13.52.38.mov

[avelino]

here we are pushing to be _blank

https://github.com/RocketChat/fuselage/blob/5b17daceeb5d13d154e5eb1e8328539b47c7f147/packages/fuselage/src/components/Message/MessageGenericPreview/MessageGenericPreviewTitle.tsx#L15-L20

[hugocostadev]

Thanks for reporting @avelino we did that because of the Desktop app, but for sure this needs to be improved...

I'll send it to the responsible team and UX to think and develop a better solution

[hugocostadev]

Related: #28826