Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embed processes markdown code blocks when it shouldn't #3467

Closed
xenithorb opened this issue Jun 5, 2016 · 5 comments
Closed

Embed processes markdown code blocks when it shouldn't #3467

xenithorb opened this issue Jun 5, 2016 · 5 comments

Comments

@xenithorb
Copy link
Contributor

xenithorb commented Jun 5, 2016

Your Rocket.Chat version: (make sure you are running the latest)
0.32.0

It's my opinion that:

  1. Rocket.Chat should not process markdown code block URLs with the AutoLinker
  2. If Refactored and reorganised entire css/less files and logic. #1 is a must, then perhaps have a preempt character so the user can turn off autolinker in-line?

Essentially it's an annoyance that after pasting a code block with URLs in it, the autolinker clutters the chat with more (probably unnecessary information) - otherwise I love the functionality when sharing regular links.

screenshot_20160605_181419

@xenithorb xenithorb changed the title AutoLinker processes markdown code blocks Embed ~~AutoLinker~~ processes markdown code blocks when it shouldn't Jun 11, 2016
@xenithorb xenithorb changed the title Embed ~~AutoLinker~~ processes markdown code blocks when it shouldn't Embed processes markdown code blocks when it shouldn't Jun 11, 2016
@xenithorb
Copy link
Contributor Author

I think this is more of a bug not a feature, no?

@qk4l
Copy link
Contributor

qk4l commented Aug 19, 2016

Rocket.Chat should not process markdown code block URLs with the AutoLinker

Agree. Another user case it is bot messages. I just wanted to improve visualizing for hubot-jira script by adding icons and links to issue (like on image below) but it's not possible because autolinker always works.
hipchat_jira_message

@martinvonwittich
Copy link

It would be nice if something could be done about this. The current behaviour is really annoying when you post apt-get update output in RC, which we do a lot in our company.

@Da-Juan
Copy link

Da-Juan commented Jun 24, 2019

Ran into this issue today.
Are there any update?

@rodrigok rodrigok added this to To do in Formatting via automation Jul 25, 2019
@rodrigok
Copy link
Member

I can't reproduce this anymore.

@Da-Juan can you let me know what rocket.chat version are you using and what text you sent to reproduce the issue?

Mean while I'll close this issue.

Formatting automation moved this from To do to Done Jul 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Formatting
  
Done
Development

No branches or pull requests

6 participants