New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Option to only play gifs on hover #4055
Comments
or play X times and then switch to on hover |
What gifs do you mean? Is there some native support for providers like imgur? I just know that https://github.com/FinndropStudios/GifRocket webhook? |
@Jellyfrog that would work too. @FibreFoX so if you post a link to a gif it'll show up and start playing. These might be posted by a user, by gifRocket etc. The idea is to not have those play automatically. Just imagine someone went a little gif crazy and pasted links to 10-15 gifs. You now have all 10-15 of those gifs playing at the same time. Eating through resources that you don't necessarily want them to be. It can bog down your chat. |
I'd love to see a play button just like Twitter does. Once the animation has completed it should stay in paused mode. Also it should remember that the Gif has been played already once so that it won't be played again if you enter the room or scroll around. |
This should be a customizable option of the user, but not "on hover", mobile devices don't have hover, "on click"/"on tap" would be nice to have available here. |
Something like this: http://rubentd.com/gifplayer/ ? |
@gabrielsixel exactly. Something that wouldn't bog down the render thread. |
@geekgonecrazy @ggazzo We could convert the GIF to .mp4 video format and use the video controls to play/pause the GIF, and also add a loop, autoplay, muted options to give it more GIFy feel if one wants to. Examples of popular website already doing this:-
This not only provides more controls with simple already built controls, but also reduces file size and improves performance of servers. |
@geekgonecrazy I am working on this feature, I will first try to implement a simple click/tap for play and stop and if that looks good may be I could do some of the optimizations mentioned above. Thanks |
@RocketChat/frontend if work here won't be accepted please chime in so no one wastes time 🙏 |
@geekgonecrazy I looked at the code and understood, what had to be done |
Please make the gif stop playing after one run or two. |
I disagree. I mean its a sane option as a default but probably better to let the user choose with a configuration option on the client side. |
GIFs need autoplay. |
@sennewood is correct. If GIFs in Rocketchat can't autoplay, is life even truly worth living? Also, I feel like GIFs used to autoplay and now they don't after an update or something. Anyone know why that may be? |
On native clients we seem to run into a problem where too many gifs playing causes the render loop to get blocked. We need to adopt what other platforms have done, and don't play them automatically. Maybe only hover?
The text was updated successfully, but these errors were encountered: