Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract addUserToRoom/removeUserFromRoom logic to separate function that doesn't require logged in user #454

Closed
rwakida opened this issue Aug 13, 2015 · 5 comments

Comments

Projects
None yet
6 participants
@rwakida
Copy link
Contributor

commented Aug 13, 2015

Use Case:
Allows automated, anonymous (bot) adding/removal of users from a room. For example, we create a channel based on a user's location, and automatically add the user to the channel.

The logic to update the ChatRoom/ChatSubscription, and create a new ChatMessage would be extracted to a new non-exposed, serverside function. The existing Method methods would check that Meteor.userId() exists, and that the current user created the room then delegates to the new methods. The backend "bots" would call the extracted method.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@engelgabriel

This comment has been minimized.

Copy link
Member

commented Aug 14, 2015

Agreed! We did something similar with sendMessage.. we should do the same with ALL methods.

@rodrigok rodrigok modified the milestone: Next Aug 15, 2015

@marceloschmidt marceloschmidt modified the milestones: Roadmap, Next Sep 21, 2015

@rodrigok rodrigok modified the milestones: Roadmap, Important Feb 23, 2016

@geekgonecrazy

This comment has been minimized.

Copy link
Member

commented May 12, 2016

With our bots now being logged in, and having our permissions system in place. Is this still relevant?

@rwakida

This comment has been minimized.

Copy link
Contributor Author

commented May 12, 2016

@geekgonecrazy I haven't kept up with the RocketChat changes, but I'm cool with closing this issue as long as bots can execute the function. This also applies to issue #455.

@engelgabriel

This comment has been minimized.

Copy link
Member

commented May 12, 2016

I don't think we should close it. We still need to move all logic from all methods into internal functions. Maybe we can re-title it?

@graywolf336

This comment has been minimized.

Copy link
Member

commented Dec 7, 2016

@engelgabriel Most of the requirements of the original request are now implemented and can be accessed in many ways, either the rest api or ddp method calls. Can this be closed now?

@engelgabriel engelgabriel modified the milestones: 0.48.0, Important Dec 12, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.