Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[i18n] Added the ability to translate "Click To Join!" #8249

Closed
mhajder opened this issue Sep 22, 2017 · 3 comments · Fixed by #8357
Closed

[i18n] Added the ability to translate "Click To Join!" #8249

mhajder opened this issue Sep 22, 2017 · 3 comments · Fixed by #8357
Labels
contrib: easy feat: i18n hacktoberfest
Milestone
0.59.0-rc.11

Comments

@mhajder
Copy link
Contributor

mhajder commented Sep 22, 2017

Rocket.Chat/packages/rocketchat-videobridge/server/methods/jitsiSetTimeout.js

Line 18 in 336f9c7

{ icon: 'icon-videocam', label: 'Click To Join!', method_id: 'joinJitsiCall', params: ''}

@mhajder mhajder changed the title Added the ability to translate "Click To Join!" [i18n] Added the ability to translate "Click To Join!" Sep 22, 2017
@MartinSchoeler
Copy link
Contributor

@rzeszow That is great! Could you create a pr for this?

@mhajder
Copy link
Contributor Author

mhajder commented Sep 27, 2017 •
edited
Loading

@MartinSchoeler
No sorry. At this moment i don't have a time.

@MartinSchoeler MartinSchoeler mentioned this issue Sep 29, 2017
Merged
@engelgabriel engelgabriel added this to the 0.59.0-rc.11 milestone Sep 29, 2017
@cyclops24
Copy link
Contributor

Part of #8175

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
contrib: easy feat: i18n hacktoberfest
Projects
None yet
Milestone
0.59.0-rc.11
Development

Successfully merging a pull request may close this issue.

[FIX] Missing i18n translations RocketChat/Rocket.Chat
6 participants
@graywolf336 @engelgabriel @gdelavald @mhajder @cyclops24 @MartinSchoeler