Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adblocker conflict with social-login class in login button #9152

Closed
hoxia opened this issue Dec 17, 2017 · 0 comments · Fixed by #9170
Closed

Adblocker conflict with social-login class in login button #9152

hoxia opened this issue Dec 17, 2017 · 0 comments · Fixed by #9170
Assignees
Milestone

Comments

@hoxia
Copy link

hoxia commented Dec 17, 2017

Description:

When using an element-hiding adblocker configured with Fanboy's Annoyances or Anti-Social lists, the Rocketchat login button is hidden. This is due to use of the class "social-login", even if the login authentication does not use or offer a "Social Media login".

I would file a bug on that list, but since this is software used on a multitude of domains, and as changing that class when the login is not "social" could be trivial (hopefully), filing it here seems more appropriate.

screen shot 2017-12-16 at 19 00 52-fullpage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants