-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LDAP Sync: final batch not processed (without pagination) #9279
Comments
@sscholl There is no hard limit in our code. Was it working before version 0.60? Could it be a hard search limit in your LDAP server configuration? |
We tested imports with more then 200.000 users with and without pagination. |
@rodrigok Thanks for your answer! I can see, that my LDAP is returning ~800 users, so my guess here is Rocket.Chat. I see the value 500 for example here in the source code:
Or is it possible, that I have a problem with asynchronous jobs? EDIT: I did not test it before 0.60. Thats my first time.
|
@sscholl That's the internal batch control, is not related with LDAP pagination. But I found the error, it's not processing the final results of the final batch, I'll fix ASAP, release a new version and let you know. Thanks |
Very nice!!! Thank you :) |
Description:
I use LDAP without pagination (by setting LDAPP_Search_Page_Size to 0), because my LDAP Server is not able to provide pragination. When I use the LDAP Sync Feature (by hand or by cronjob), 500 users are imported at maximum. I guess this is because of the missing pagination feature, but my LDAP sends all ~800 users.
Can you increase the default value or make it configurable?
Thank you!!!
Server Setup Information:
Steps to Reproduce:
Expected behavior:
All LDAP Users shoud be imported (more than 500).
Actual behavior:
Only 500 users are imported.
After log message
LDAPSync ➔ info Import running. Users imported until now: 500
import stops.Relevant logs:
20171229-11:58:44.846(0) rocketchat_logger rocketchat_logger.js:278 LDAPSync ➔ info Import running. Users imported until now: 500
The text was updated successfully, but these errors were encountered: