Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Error when editing priority and required description #19170

Merged
merged 1 commit into from Oct 7, 2020

Conversation

MartinSchoeler
Copy link
Contributor

@MartinSchoeler MartinSchoeler commented Oct 7, 2020

Proposed changes

Issue(s)

How to test or reproduce

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Hotfix (a major bugfix that has to be merged asap)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Changelog

Further comments

@ggazzo ggazzo merged commit 67b3f5f into develop Oct 7, 2020
@ggazzo ggazzo deleted the priorities-fix branch October 7, 2020 23:23
gabriellsh added a commit that referenced this pull request Oct 26, 2020
* wip

* wip

* more work in progress

* lint

* Fix IE11 support livechat widget

* More wip

* lint

* Add correct buttons and fix some errors

* fix import

* Fix error with empty department agents

* fix title and tags

* more fixes

* fix agents save

* Fix agentlist not saving

* First Review

* update fuselage

* Sidebar variations

* Fix Stories

* Sidebar Header

* Initial data

* Fix paddings

* sidebar search

* Wip Chats

* Added more logic

* Fix Memo

* Virtual List

* switch to VariableSizeList

* Fix Size

* Te acalma Gabriel

* Badges

* Menu actions

* Do not group by type option

* Highligthed state

* Fix menu

* Item Skeletons

* Search list

* Omnichannel to virtualList

* Sidebar header

* SidebarHeader

* Better Ominichannel Context usage

* Revome livechat template

* Remove discussion Room List

* alert and open prop

* Menu as renderprop

* ReactiveUserPresence

* Update components

* Update cachedCollection

* Fiz discussions

* update cachedcolletion

* Header color

* Fix unread

* Presence

* Fix presence

* Fix Admin

* [wip] Search bar

* get usernames in subscription

* Local an spotlight search

* Fix avatar id prop

* Fix multi users on search

* Livechat RoomMenu

* Fix Header in anonymous sessions

* Fix sidebar

* update base old

* Sidebar variations

* Fix Stories

* Sidebar Header

* Initial data

* Fix paddings

* sidebar search

* Wip Chats

* Added more logic

* Virtual List

* Fix Memo

* switch to VariableSizeList

* Fix Size

* Te acalma Gabriel

* Badges

* Menu actions

* Do not group by type option

* Highligthed state

* Item Skeletons

* Search list

* Fix menu

* Omnichannel to virtualList

* Sidebar header

* SidebarHeader

* Better Ominichannel Context usage

* Revome livechat template

* Remove discussion Room List

* alert and open prop

* Menu as renderprop

* ReactiveUserPresence

* Update components

* Update cachedCollection

* Fiz discussions

* update cachedcolletion

* Header color

* Fix unread

* Presence

* Fix presence

* Fix Admin

* [wip] Search bar

* get usernames in subscription

* Local an spotlight search

* Fix avatar id prop

* [FIX] Missing "Bio" in user's profile view  (#19166)

* [FIX] Omnichannel: triggers page not rendering (#19134)

* [FIX] VisitorAutoComplete component (#19133)

* [FIX] Admin Sidebar overflowing (#19101)

* [FIX] Integrations history page not reacting to changes. (#19114)

* [FIX] Selecting the same department for multiple units (#19168)

* [FIX] Error when editing priority and required description (#19170)

* [FIX] Thread view in a channel user haven't joined (#19172)

* [FIX] Livechat Appearance label and reset button (#19171)

* Refactor: Omnichannel departments (#18920)

Co-authored-by: Guilherme Gazzo <guilherme@gazzo.xyz>
Co-authored-by: Gabriel Henriques <gabriel.henriques@rocket.chat>
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>

* Fix multi users on search

* Livechat RoomMenu

* Fix Header in anonymous sessions

* Fix sidebar

* Fix admin user Info

* update base old

* fix sidebar size

* Fix sidebar tests

* Lint

* Package-lock

* package-lock

* Fix callback

* Removed  useless files

* Fix LGTM

* Isolate userpresence to dont leak react and fuselage

* Fix Alert

* update fuselage

* fix hide modal not closing

* Sort by name and activity

* Fix reset

* Arrow controls (#19239)

Co-authored-by: Guilherme Gazzo <guilherme@gazzo.xyz>

* Fixes

* ActionButton

* ActionButton[2]

* ActionButton [3]

* Support anonymous

* Open menu by keyboard

* Login button for anonymous users

* Login button for anonymous users

* Update code

* ShouldUpdate

* Change login Icon, fix badge

* Update fuselage

* Fix storybook

* Fix storybook

* Use Style and renamed

* wip stories sidebar

* Types

* wip

* Testing IE11

* WIP

* Fix Typo

* Use Layout colors

* Lint

* Fix

* Remove CallProvider

* Remove CallContext

Co-authored-by: Martin <martin.schoeler@rocket.chat>
Co-authored-by: Gabriel Henriques <gabriel.henriques@rocket.chat>
Co-authored-by: Douglas Fabris <deefabris@gmail.com>
Co-authored-by: gabriellsh <40830821+gabriellsh@users.noreply.github.com>
Co-authored-by: Renato Becker <renato.augusto.becker@gmail.com>
Co-authored-by: Tasso Evangelista <tasso.evangelista@rocket.chat>
@sampaiodiego sampaiodiego mentioned this pull request Nov 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants