Skip to content
This repository has been archived by the owner on Mar 17, 2023. It is now read-only.

/api/v1/me needs better documentation for the preferences #695

Closed
cardoso opened this issue Apr 17, 2018 · 4 comments
Closed

/api/v1/me needs better documentation for the preferences #695

cardoso opened this issue Apr 17, 2018 · 4 comments
Labels

Comments

@cardoso
Copy link
Contributor

cardoso commented Apr 17, 2018

https://rocket.chat/docs/developer-guides/rest-api/authentication/me/

There are a number of preferences shown in the example result, but these are the only ones I receive:

{
    "sidebarViewMode": "condensed"
    "sidebarShowUnread": true
    "sidebarHideAvatar": false
    "sidebarShowFavorites": true
}

Problems:

  1. None of these are in the example.
  2. There is no description of what they do.

Possible solutions:

  1. Include these in the example.
  • Explain why all the others may not come in the result.
  • If they should never come, then remove them from the example)
  1. Describe what each preference does (maybe in a separate doc)
@cardoso cardoso added the API label Apr 17, 2018
@MartinSchoeler
Copy link
Collaborator

I believe that only preferences that has been changed appear in this list, since this is default behavior in Rocket.Chat, i could be wrong @MarcosSpessatto any ideas?

@cardoso
Copy link
Contributor Author

cardoso commented Apr 17, 2018

I think that's the case @MartinSchoeler

Then how do we know the defaults without hardcoding them? Maybe we should alter this API to return all settings regardless.

@MarcosSpessatto
Copy link
Member

Yes @MartinSchoeler, you're right, only preferences that has been changed appear in this list, this is the behaviour on backend. If you don't changed the preferences yet, then the list should be empty, because they're not save on db.

@MarcosSpessatto
Copy link
Member

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants