Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display quoted message above the user message #688

Closed
Otiel opened this issue Feb 21, 2018 · 41 comments · Fixed by RocketChat/Rocket.Chat#32605
Closed

Display quoted message above the user message #688

Otiel opened this issue Feb 21, 2018 · 41 comments · Fixed by RocketChat/Rocket.Chat#32605

Comments

@Otiel
Copy link

Otiel commented Feb 21, 2018

When quoting a message using the "Quote" or "Reply" action, I think it would be better if the quoted message appeared above the user message, not below as it is done currently:

image

This was already asked here, I'm creating this issue to trace this more easily.

@ugzv
Copy link

ugzv commented Oct 1, 2018

I think the current quote and reply message structure is likely to be confusing.

It would be better to show:

  1. Quote
  2. Reply

@yenda23
Copy link

yenda23 commented Jan 25, 2019

It would be nice to have it configurable this behaviour.

@tassoevan tassoevan transferred this issue from RocketChat/Rocket.Chat Feb 18, 2019
@jpenna
Copy link

jpenna commented Mar 15, 2019

Configurable might be harder to implement, and this feature was requested more than 1 year ago.

Is there any reason why someone would want to see the replied message after the reply?

@mmickelson
Copy link

I agree with this request. Reading the quote after the reply is confusing. It's much more readable to see something like:

Question or quoted message

Answer/reply

Configurable would be nice but I imagine the majority of people would would prefer to see the quote below the reply so I would say implement the hard-coded behavior and if it's requested to have it configurable, add another feature request specifically for that.

@ankar84
Copy link

ankar84 commented Oct 21, 2019

I agree with this request.
It will be so nice to add the optional choice of displaying quotes in the Telegram and WhatsApp style (quoted text above, answer below)
and in the Rocket.Chat style (where the answer is located to above, and the quoted message is lower than the answer).

@zedar187
Copy link

Bump :)

@infused-kim
Copy link

From me too. Please implement.

@neomag
Copy link

neomag commented Oct 16, 2020

Please implement

@prigal
Copy link

prigal commented Nov 6, 2020

Indeed it's a weird pattern, it should at least be configurable imo.

Upvoted.

@svedrenne
Copy link

svedrenne commented Nov 20, 2020

Please implement "Reply below" or "Quoted message above reply". Very Nice To Have

Upvoted (with "thumbs up")

@kyletmiller
Copy link

thanks for a great platform! adding support for this request.

@ankar84
Copy link

ankar84 commented Jan 29, 2021

@rodrigok Hello, Rodrigo!
Please take a look at that feature request.
A lot of users asked for it more then 2 years now.

@jaykobi
Copy link

jaykobi commented Apr 7, 2021

Like it is now I sometimes see that there is a quote only after I read the reply.
Much better to display the quote first.

@helgator
Copy link

Does anyone comprehend the logic behind "quote after reply" and can explain it? Maybe we are all just using RC the wrong way.

@rodrigok
Copy link
Member

@helgator no, it's wrong, we are refactoring the messages and it will be fixed. It was made like that because we used the attachments component to display the content, and attachments were only available below the message.

@ankar84
Copy link

ankar84 commented Apr 30, 2021

we are refactoring the messages and it will be fixed

Really glad to hear that! Thank you for that work!

@tmkis2
Copy link

tmkis2 commented Oct 12, 2021

Just to bump it again: Any news on this? Any workaround to get this behavior changed before it get implemented?

@engelgabriel
Copy link
Member

@ggazzo we should add this as part of the message refactoring into react.

@prayingmantis1979
Copy link

I've got many complains from users about current style of quoting :(

@Feuermurmel
Copy link

If this is touched, I'd also love to see the original message truncated to e.g. a maximum of two lines. Right now, the message flow is sometimes completely disrupted when long messages are quoted. Please have a look at how Telegram Messenger is doing this. IMHO they have the best UI for replies, I use it a lot and I never have trouble.

@MrVonkey
Copy link

MrVonkey commented Mar 2, 2022

Would it be possible to temporarily add an additional CSS class to the message component for quotes until the message component is refactored? This would allow admins to place quotes above the messages with custom CSS, e.g. with flex, and would allow excluding file attachments from the custom CSS. At the moment we are using the following custom CSS, which messes up the display position of the username (below file attachments and quotes):

.message {
  display: flex;
  flex-direction: column;
}

.message > * {
 order: 1; 
}

.message > div:not([class]) {
  order: 0;
}

Not optimal, but still an improvement for readability in my opinion.

@skjardenCode
Copy link

Since beginning of April 2022, I started using RocketChat. I was very confused by quoted messages below the answer. I also vote to change this. The reading direction (flow of chat) is top to bottom, so should be the quote-answer direction.

@ankar84
Copy link

ankar84 commented May 24, 2022

Great news - RocketChat/Rocket.Chat.ReactNative#3883 introduces proper direction of quotes on mobile!
Kudos to mobile team!
Still waiting for Web client implementation...

@EdSantos754
Copy link

C'mon guys, this is something really annoying in the rocket.chat interface. It confuses people and gets in the way of the natural flow of conversations. It's been too many years. This should be prioritized over other less useful features, as it is a daily problem that our online communities face. Thanks.

@MrVonkey
Copy link

MrVonkey commented Jul 4, 2022

C'mon guys, this is something really annoying in the rocket.chat interface. It confuses people and gets in the way of the natural flow of conversations. It's been too many years. This should be prioritized over other less useful features, as it is a daily problem that our online communities face. Thanks.

Yes absolutely, this should be prioritized. Unfortunately I couldn't find anything concerning this in the changelog for the 5.0.0 release candidate. Maybe I missed something, since there are several issues/requests related to this?

@MrVonkey
Copy link

Since version 5.0.0 there are more possibilities to customize the layout of the message component. You can try the following custom CSS in Settings > Layout to place the username / message header above the quoted message block and everything else below the quoted message block:

.rcx-message-container > div {
 order: 2; 
}

.rcx-message-container > div.rcx-message-header {
  order: 0;
}

.rcx-message-container > div.rcx-attachment__content {
  order: 1;
}

@engelgabriel engelgabriel transferred this issue from RocketChat/feature-requests Oct 19, 2022
@engelgabriel
Copy link
Member

@ggazzo can we do that with the new message parser?

@ggazzo
Copy link
Member

ggazzo commented Oct 19, 2022

it's not a message parser issue, it's a design definition, which can be changed if it makes sense

@ankar84
Copy link

ankar84 commented Oct 20, 2022

@engelgabriel @ggazzo it definitely make sense!! All that issue with many comments and reactions a good illustration of fact, community need that important improvement a lot!

@engelgabriel
Copy link
Member

@ggazzo can you link the PR that fixed this here?

@ggazzo
Copy link
Member

ggazzo commented Dec 21, 2022

we will never have a pr who fixes this, because this is not a issue/bug.

This is a design change, based on user input or feature/improvement request.

I will put the design team in the loop, if they believe this is the best option, I'm sure it will be implemented soon

btw this is something that @milton-rucks can help as well

@engelgabriel
Copy link
Member

@dudanogueira did someone already work on this?

@milton-rucks
Copy link

I agree with the change. We are considering it for the next semester.

@dudanogueira
Copy link

@dudanogueira did someone already work on this?

Oooops! For some reason I believed this was delivered in 5.4, as I mentioned at our monthly Community Open Call

But it was not. Sorry! But worry not!

Now we have everything in place to deliver this and the dark mode (that you can already preview with that cool Easter Egg) in 6.0

@hugocostadev hugocostadev transferred this issue from RocketChat/Rocket.Chat Mar 30, 2023
@rp-sg
Copy link

rp-sg commented May 31, 2023

Is this possible yet?

@nguyennhatdung
Copy link

i think we shoud wait rocket chat version 100 for this...

@tmkis2
Copy link

tmkis2 commented Jul 10, 2023

I mentioned in on two community calls but nothing happened so far. :-(

@istankovic
Copy link

A lot of users asked for it more then 2 years now.

Counting 5 years now...

@brlarini
Copy link

brlarini commented Nov 1, 2023

@dudanogueira did someone already work on this?

Now we have everything in place to deliver this and the dark mode (that you can already preview with that cool Easter Egg) in 6.0

We're already at 6.4.4 and this still isn't a thing...

@DRKMDMZ
Copy link

DRKMDMZ commented Nov 4, 2023

Well I guess it will be added sometime in the 6.4 or 6.5 update - but then it will bekome a "premium feature" like read receipts are.

@casalsgh
Copy link

Since 2018 this ticket has been open. Thanks all for sticking with us to see it though - Took us a while, but we heard you and now it's closed, with new display of quoted messages going out on release 6.10.0.

Thanks to our community liaison reetp (John), MartinSchoeler and folks from internal teams reviews for making it happen!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.