Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(fuselage): ModalThumb size #1048

Merged
merged 2 commits into from
May 15, 2023
Merged

fix(fuselage): ModalThumb size #1048

merged 2 commits into from
May 15, 2023

Conversation

juliajforesti
Copy link
Contributor

@juliajforesti juliajforesti commented May 9, 2023 •
edited

DSAR-119

Proposed changes (including videos or screenshots)

change ModalThumb default size to 28x28

Issue(s)

Further comments

@juliajforesti juliajforesti changed the title fix(fuselage): ModalIcon and ModalThumb size fix(fuselage): ModalThumb size May 10, 2023
@juliajforesti juliajforesti marked this pull request as ready for review May 10, 2023 16:30
@juliajforesti juliajforesti requested a review from a team May 11, 2023 14:45
@dougfabris
Copy link
Member

@juliajforesti ModalIcon will not be changed?

@juliajforesti
Copy link
Contributor Author

@juliajforesti ModalIcon will not be changed?

no, only ModalThumb - that's the one used on Apps

ModalIcon should remain 20x20

@dougfabris dougfabris merged commit 3812ee3 into develop May 15, 2023
8 checks passed
@dougfabris dougfabris deleted the fix/ModalIcon-size branch May 15, 2023 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougfabris dougfabris dougfabris approved these changes

Assignees
No one assigned
Labels
📦 fuselage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@juliajforesti @dougfabris