feat: Add Modal Icon to Modal Component #410

dougfabris · 2021-03-03T22:03:15Z

I have read the Contributing Guide
I have signed the CLA
Lint and unit tests pass locally with my changes
I have labeled the PR correctly with the related package
I have run Loki's visual regression tests (if applicable)
I have added tests that prove my fix is effective or that my feature works (if applicable)
I have added necessary documentation (if applicable)
Any dependent changes have been merged and published in downstream modules

Proposed changes (including videos or screenshots)

Add a new Icon option on Modal as Modal.Icon

add modal-icon

cd2ddab

dougfabris added the 📦 fuselage-hooks label Mar 3, 2021

dougfabris requested a review from a team March 3, 2021 22:04

dougfabris changed the title ~~improve: Add ModalIcon to Modal Component~~ improve: Add Modal Icon to Modal Component Mar 3, 2021

Merge branch 'develop' into new/modal-icon

5b7073d

tassoevan temporarily deployed to github-pages March 7, 2021 02:34 Inactive

ggazzo approved these changes Mar 22, 2021

View reviewed changes

ggazzo changed the title ~~improve: Add Modal Icon to Modal Component~~ feat: Add Modal Icon to Modal Component Mar 22, 2021

ggazzo merged commit c6a8b3e into develop Mar 22, 2021

ggazzo deleted the new/modal-icon branch March 22, 2021 20:20

This was referenced Sep 13, 2023

Version Packages [TEST PROPOSAL] #1164

Closed

Version Packages #1166

Closed

Version Packages #1167

Merged