New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adonis V5 migration #50
Comments
Tava fazendo alguns testes j谩 com o pacote, n茫o sei se voc锚s j谩 realizaram o ajuste, caso sim pode desconsiderar. Mas ele d谩 um erro com a conex茫o ao redis, pq nas linhas 40 e 116, ele passa o objeto BullConnectionContract inteiro, e n茫o apenas a configura莽茫o definida. |
Hi @ruanitto 馃 We are making some changes, but could you give us more information about the error? |
Finally馃 |
Sorry I don't talk Portuguese and I'm just trying to help :) I don't know if this is related but some of the instructions in the README file is wrong/incomplete about how to configure the connection. I've updated the README in fork so feel free to consult it: https://github.com/ashokgelal/adonis-bull Basically, there are two steps missing/incomplete in the README:
import Env from '@ioc:Adonis/Core/Env'
import { BullConfig } from '@ioc:Rocketseat/Bull'
const bullConfig: BullConfig = {
connection: Env.get('BULL_CONNECTION', 'bull'),
connections: {
bull: {
host: Env.get('BULL_REDIS_HOST'),
port: Env.get('BULL_REDIS_PORT'),
password: Env.get('BULL_REDIS_PASSWORD', ''),
db: 0,
keyPrefix: '',
},
}
}
export default bullConfig Happy to help you on the Adonis discord server if you need more help. |
No problem, we're talking in English by default, as this package isn't only used by people who speak Portuguese. Thx you for your report, but we added all the necessary setup for the bull configuration in the |
Sorry, my English is not very good, I ended up using the google translator but at the time it was kind of curled up and I ended up writing in Portuguese. I did all the configuration really according to your repository, but the connection to the redis failed, I performed the debug, and in the BullManager.ts file, there was an error when passing the connections to Bull, but it has already been fixed. |
My suggestion is keep migration in alpha branch and in typescript as adonis v5 is mostly in ts. |
Hey @zulfi007, we will do that. The documentation and code for version 5 will be on a separated branch (named |
Hey guys, the support for version 5 was officially released 馃帀 It is a premajor, and may contain bugs, but we encourage you to use it on your projects and report any problem you may have. To get started with it, you can install it with NPM or Yarn: yarn add @rocketseat/adonis-bull@alpha
# or
npm install @rocketseat/adonis-bull@alpha After installing it, run You can find the complete documentation here, and if you want to add more examples or guides, don't hesitate to open a PR! |
Great @jpedroschmitz! Will install it tomorrow :) |
We're working on integration with adonis v5.
馃毀 Roadmap
Special thanks @RodolfoSilva for initializing the implementation in PR #39
The text was updated successfully, but these errors were encountered: