New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The items are added to the inventory with a slight delay on join #229
Comments
Uhhh 5.0.5-SNAPSHOT doesn't exist? Also, the delay is intentional, tweaking the items-Delay in the items.yml will make the delay longer or shorter. So simply setting it to zero will make the delay disappear. |
@RockinChaos Sorry, I was wrong, it's 5.0.4-SNAPSHOT, however I've set items-Delay to 0 but that's the same |
Okay so, I have done some digging and there are a couple of things. 2.) The ONLY time there will be a bigger delay is if you have Clear-Items ENABLED in the config.yml for any of the triggers such as join or world-change. This is because of the Delay-Tick, which is only active if ItemJoin is actually clearing the player's inventory. So what happens is if the Delay-Tick is a greater value than the items-Delay the items-Delay will be equal to the Delay-Tick + 1 tick. That way ItemJoin doesn't clear its own items haha. (As I do not have your config.yml I cannot see if this applies in your case but I thought it was some helpful info). |
@RockinChaos that option for me is disabled (as default), I think that is because on player join there is a scheduled task that runs, and even if with 0 delay, makes the code executing the next tick |
Heeeyy there! Nice eye, I actually thought the tasks were (not) being ran async but it turns out when taking another looks at it they are being run async which is actually causing it to run 10 ticks later (about half a second). There is a big difference when removing the task and letting it run. Looks like I have a job to do ;) EDIT: Should be resolved in the latest snapshot; http://ci.craftationgaming.com/job/ItemJoin/288/ |
This bug has been officially fixed in the release of ItemJoin v5.0.4. Please read the changelog as the documentation has not been updated yet; |
1.) Vesion: 5.0.4-SNAPSHOT.
2.) Spigot 1.14.4.
3.) The items are added to the inventory with a slight delay on player join, so it causes that you can see, for a moment, that the items are missing
The text was updated successfully, but these errors were encountered: