Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix display of record created for spurious characters between games in PGN files. #3

Open
RogerMarsh opened this issue Mar 19, 2024 · 0 comments

Comments

@RogerMarsh
Copy link
Owner

The sequence '... 1. e4 1-0 ff\n\n[Event ...' where the '1-0' ends a valid game and the '[Event' starts a valid game creates records for the two games plus a record for the invalid game 'ff'.

A hack was added to avoid crashes when attempting to display the PGN headers for the invalid game 'ff'.

Scrolling the list of games does not happen when the scroll action would bring the 'ff' game onto the display. The 'ff' game should be displayed in the 'Error' list but is not. Scrolling for an index is fine because the 'ff' game has no PGN tags and the game is not displayed in the list for any index.

'ff' cases have been seen in real PGN files, but it is assumed other character sequences with the effect described here are possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant