Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistency between paper and code #4

Open
Turlan opened this issue Jan 3, 2020 · 2 comments
Open

Inconsistency between paper and code #4

Turlan opened this issue Jan 3, 2020 · 2 comments

Comments

@Turlan
Copy link

Turlan commented Jan 3, 2020

Thanks for releasing codes!
I found several differences between the paper and the released code:

  1. The batch size. In your paper, the batch size of segmentation model was set as 1, in your code, the default batch size is 4.
  2. The ASPP module is different with a common design. You use concat and conv instead of sum
    x = torch.cat((x1, x2, x3, x4, x5), dim=1)
  3. The decoder uses low-level feature as input
    def forward(self, x, low_level_feat):

I wanna know if I just set the batch size to 1 as the paper described, is there a signifigent performance drop? What's the reason of the design for the decoder? Is it necessary to use low-level feature?

@Turlan
Copy link
Author

Turlan commented Jan 3, 2020

And could you release/explain the code for updating CAC between stages? In the released code, there exists a moving-average implementation. Which one did you use?

def update_objective_SingleVector(self, id, vector, name='moving_average', ):

@RogerZhangzz
Copy link
Owner

Hi there,
Thanks for your suggestion.

  1. The batch size was set to 1 when I trained the model. Then in my re-implementation, I set it to 4 for a quick convergence. Both settings would be fine for the final performance. Plz note that you have to increase the crop size if you choose to use 1 as the batch size.

  2. \ 3. Very thank you for what you have pointed out. I will check it out.

  3. I have uploaded the CAC code (cac.py) and modified the instructions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants