Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Update Webhook Channel ID if channel ID has changed. #1791

Merged
merged 1 commit into from
Mar 10, 2021
Merged

Fix: Update Webhook Channel ID if channel ID has changed. #1791

merged 1 commit into from
Mar 10, 2021

Conversation

AntiTcb
Copy link
Collaborator

@AntiTcb AntiTcb commented Mar 4, 2021

Fixes #1447.

@AntiTcb AntiTcb changed the title Update Webhook Channel ID if channel ID has changed. Fix: Update Webhook Channel ID if channel ID has changed. Mar 4, 2021
SubZero0
SubZero0 requested changes Mar 4, 2021
View reviewed changes
Copy link
Member

@SubZero0 SubZero0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Channel property is still outdated and might not match the ChannelId anymore.

@AntiTcb
Copy link
Collaborator Author

AntiTcb commented Mar 8, 2021

Channel property is still outdated and might not match the ChannelId anymore.

It'll have to remain outdated, there's no means of getting a fresh Channel object without hitting the API.
If we want to remove the property altogether, that should be done in a separate PR.

@SubZero0
Copy link
Member

SubZero0 commented Mar 8, 2021

It'll have to remain outdated, there's no means of getting a fresh Channel object without hitting the API.

It's fine if we can't remove it (much less in a patch), but it should be noted that it might be outdated and using the ChannelId property is more reliable as a remark or similar so there's less chance of people getting an unexpected value from it.

@SubZero0
Copy link
Member

I just noticed the Channel is internal and not used anywhere so nevermind.

@SubZero0 SubZero0 merged commit d2518db into discord-net:dev Mar 10, 2021
This was referenced Mar 11, 2021
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Closed
Closed
Merged
Merged
Closed
@dependabot dependabot bot mentioned this pull request Mar 18, 2021
Closed
anonymousheadless pushed a commit to anonymousheadless/Discord.Net that referenced this pull request Mar 29, 2021
@AntiTcb
fix: Update Webhook ChannelId from model change (discord-net#1791)
9f4c048
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SubZero0 SubZero0 SubZero0 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Modifying a webhook's channel doesn't actually modify it?
2 participants
@AntiTcb @SubZero0