Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up Travis to deploy tagged commits to Github Releases #49

Closed
RohanNagar opened this issue Jan 27, 2018 · 2 comments
Closed

Set up Travis to deploy tagged commits to Github Releases #49

RohanNagar opened this issue Jan 27, 2018 · 2 comments
Assignees
Labels
Type: Bug Addresses a code bug. Type: Dev Tools Relates to development tools like Maven, code coverage, integration tests, Travis CI, and more.

Comments

@RohanNagar
Copy link
Owner

Step 1 in the containerization and deployment process.

Travis should continue to build and report status as normal, but additionally on tagged commits (commits that are intended to be a new version of Thunder), the application jar should be added to the release.

This is more of a consolidation into Github as a platform, and not relying on AWS S3 to hold our releases. We should use JitPack going forward for including the api and client modules in other projects, instead of relying on S3. This will improve the development process for Lightning, as AWS keys will no longer be needed to build.

@RohanNagar RohanNagar added the Type: Dev Tools Relates to development tools like Maven, code coverage, integration tests, Travis CI, and more. label Jan 27, 2018
@RohanNagar RohanNagar self-assigned this Jan 27, 2018
@RohanNagar
Copy link
Owner Author

Made some changes to .travis.yml in 9e80dda.

However, this is still broken. The application jar is not published to Github releases on a tagged commit because Travis currently only does a test, not a package.

We should update the script to run a full mvn clean package.

Also, for easier release pushes we need to change the maven-release-plugin to only install and not attempt to publish the artifacts.

@RohanNagar RohanNagar added the Type: Bug Addresses a code bug. label Feb 6, 2018
@RohanNagar
Copy link
Owner Author

We need to update the branch restriction on Travis to include this regex: ^[v](\d+\.)?(\d+\.)?(\d+)$. This will match the format of tagged commits, allowing Travis to build them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Addresses a code bug. Type: Dev Tools Relates to development tools like Maven, code coverage, integration tests, Travis CI, and more.
Projects
None yet
Development

No branches or pull requests

1 participant