Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix continue for #65

Merged
merged 2 commits into from
Dec 9, 2022
Merged

Fix continue for #65

merged 2 commits into from
Dec 9, 2022

Conversation

iBicha
Copy link
Contributor

@iBicha iBicha commented Dec 9, 2022

Closes #63

TwitchBronBron
TwitchBronBron requested changes Dec 9, 2022
View reviewed changes
Copy link
Member

@TwitchBronBron TwitchBronBron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! We don't have dedicated Continue For or Continue While tokens in brighterscript because the word continue may be used as an variable/function name, so this PR is exactly how I would have implemented it as well! Thanks for putting the time in.

The CI failed because of some formatting issues. can you please fix them, and then this is good to go!

image

@TwitchBronBron TwitchBronBron merged commit 63beadb into rokucommunity:master Dec 9, 2022
@iBicha
Copy link
Contributor Author

iBicha commented Dec 14, 2022

@TwitchBronBron I tried, but it is not working.
In 1.6.20, I inspected the transpiled IndentFormatter.js file, and the change is not included.
Was there a missing build step perhaps?

@TwitchBronBron
Copy link
Member

Oh. Silly me. When I was doing the latest vscode release, I forgot to also do this formatter release. I was mistaken, this has not been released yet. Sorry for the mixup. I'll start cutting this release today and let you know when it's actually released.

@iBicha
Copy link
Contributor Author

iBicha commented Jan 3, 2023

Oh. Silly me. When I was doing the latest vscode release, I forgot to also do this formatter release. I was mistaken, this has not been released yet. Sorry for the mixup. I'll start cutting this release today and let you know when it's actually released.

I did not have a change to check, but now I confirm this works. Thanks!

@iBicha iBicha deleted the fix/continue-for branch January 3, 2023 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TwitchBronBron TwitchBronBron TwitchBronBron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

continue for causes formatting to be not indented properly
2 participants
@iBicha @TwitchBronBron