Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File api #408

Merged
merged 68 commits into from Oct 16, 2023
Merged

File api #408

merged 68 commits into from Oct 16, 2023

Conversation

TwitchBronBron
Copy link
Member

@TwitchBronBron TwitchBronBron commented May 7, 2021

Moves file handling into plugin-land so plugins can contribute custom file types. (Migrated from #387 )

Notable changes:

  • added plugin event onProvideFile (and beforeProvideFile/afterProvideFile events too). Plugins can add files to the .files array of the event.
  • All files found in the files array that exist on disk will be included in the program. Files not handled by plugins and bsc will be loaded as AssetFile instances, and are copied as-is. (this will help support the custom tree view we wanted to add in vscode but couldn't because non xml and brs files were missing)
  • Defined a new interface called File that desribes the important parts of a file. This makes most file properties optional, so plugin-contributed files only add what they actually implement.
  • add beforeFileRemove and afterFileRemove events, deprecate beforeFileDispose and afterFileDispose events.
  • add beforeFileAdd and afterFileAdd events that are triggered after the provide events for every file that plugins create.

@TwitchBronBron TwitchBronBron changed the title File api File api (v1) Sep 20, 2022
@TwitchBronBron TwitchBronBron changed the base branch from v1 to master September 20, 2022 16:53
@TwitchBronBron TwitchBronBron changed the title File api (v1) File api Sep 20, 2022
@TwitchBronBron TwitchBronBron removed the v1 label Sep 20, 2022
@TwitchBronBron TwitchBronBron changed the base branch from master to release-0.66.0 October 12, 2023 20:10
@TwitchBronBron TwitchBronBron merged commit 629ead3 into release-0.66.0 Oct 16, 2023
3 checks passed
@TwitchBronBron TwitchBronBron deleted the file-api branch October 16, 2023 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add all files to the program
1 participant