Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes compatibility of built in types (roArray -> typed arrays) #925

Merged
merged 4 commits into from Oct 4, 2023
Merged

Fixes compatibility of built in types (roArray -> typed arrays) #925

merged 4 commits into from Oct 4, 2023

Conversation

markwpearce
Copy link
Collaborator

Also fixes type compatibility for string -> roString, etc.

roArray is basically the same as dynamic[]

TwitchBronBron
TwitchBronBron approved these changes Oct 4, 2023
View reviewed changes
Copy link
Member

@TwitchBronBron TwitchBronBron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few comments. I'm not a huge fan of comparing types by their names, but this is a good functionality move forward. It's up to you if you want to tackle them now or just keep it in mind for the future.

src/types/ArrayType.ts Outdated Show resolved Hide resolved
src/types/InterfaceType.ts Outdated Show resolved Hide resolved
@markwpearce markwpearce merged commit 38d6de3 into release-0.66.0 Oct 4, 2023
5 checks passed
@markwpearce markwpearce deleted the fix/roArray_compatibility branch October 4, 2023 17:33
@TwitchBronBron TwitchBronBron added this to the v1.0.0 milestone Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TwitchBronBron TwitchBronBron TwitchBronBron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@markwpearce @TwitchBronBron