Semantic Tokes for Native Components and Type completion in Type Expressions #927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markwpearce
commented
Oct 5, 2023
| @@ -412,6 +412,11 @@ export class Parser { | |||
| }); | |||
| //consume the statement separator | |||
| this.consumeStatementSeparators(); | |||
| } else if (this.peek().kind !== TokenKind.Identifier && !this.checkAny(...DeclarableTypes, ...AllowedTypeIdentifiers)) { | |||
There was a problem hiding this comment.
Only try to find a type if the next token can be a type identifier -- basically, don't throw an exception if there isn't the correct kind of token next.
This is important so that we can do completions inside this expression
TwitchBronBron
approved these changes
Oct 6, 2023
| }]); | ||
| }); | ||
|
|
||
| it('only shows intrinsic/native types in brightscript', () => { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Semantic tokens for Components Types/Interfaces:
Code completion in Type Cast/Type Expression: