Adds callFunc as member method to Custom Components
#929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markwpearce
commented
Oct 6, 2023
| @@ -2278,7 +2278,7 @@ describe('Program', () => { | |||
| expectTypeToBe(table.getSymbolType('ifDeviceInfo', opts).getMemberType('GetRandomUUID', rtOpts), TypedFunctionType); | |||
|
|
|||
| expectTypeToBe(table.getSymbolType('ifSGNodeField', opts), InterfaceType); | |||
| expectTypeToBe(table.getSymbolType('ifSGNodeField', opts).getMemberType('observeField', rtOpts), TypedFunctionType); | |||
| expectTypeToBe(table.getSymbolType('ifSGNodeField', opts).getMemberType('addFields', rtOpts), TypedFunctionType); | |||
There was a problem hiding this comment.
Needed to change this because there observeField is overloaded, so it is actually a UnionType... see: #926
TwitchBronBron
requested changes
Oct 6, 2023
src/types/ComponentType.ts
Outdated
| CallFuncMemberMethod.isVariadic = true; | ||
|
|
||
| // Taken from: https://developer.roku.com/en-ca/docs/developer-program/core-concepts/handling-application-events.md#functional-fields | ||
| export const CallFuncDescription = `callFunc() is a synchronized interface on roSGNode. It will always execute in the component's owning ScriptEngine and thread (by rendezvous if necessary), and it will always use the m and m.top of the owning component. Any context from the caller can be passed via one or more method parameters, which may be of any type (previously, callFunc() only supported a single associative array parameter).\n\nTo call the function, use the \`callFunc\` field with the required method signature. A return value, if any, can be an object that is similarly arbitrary. The method being called must determine how to interpret the parameters included in the \`callFunc\` field.`; |
There was a problem hiding this comment.
Would it work to move this into the scrape-roku-docs.ts instead, so it shows up in the data.json? Just add a hardcoded function. That way this data flows the same as all the others.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
callFuncmemberisVariadicflag toTypedFunctionType, because CallFunc() may have any number of arguments