Prevent errors when using enums in a file that's not included in any scopes

[josephjunker]

When running compilation on one of our projects I encountered this error:

Error when calling plugin BscPlugin.beforeFileTranspile: TypeError: Cannot read properties of undefined (reading 'getEnumMemberFileLink')
    at BrsFilePreTranspileProcessor.getEnumInfo (/Users/jjunker/code/my-application/common/temp/node_modules/.pnpm/brighterscript@0.65.14/node_modules/brighterscript/dist/bscPlugin/transpile/BrsFilePreTranspileProcessor.js:38:32)
    <long stack trace here>

This occurs when a file which uses enums is not found in any scope. The relevant unit test wasn't testing enums and was suppressing errors, so I expanded the functionality of the unit test. The actual fix is the added null coalescing operator on line 44 of src/bscPlugin/transpile/BrsFilePreTranspileProcessor.ts.

There are some changes here that are not directly tied to the bug fix at hand. This is because I traced through other usages of Program.getFirstScopeForFile to check whether any other locations might have the same error. Doing so lead me to src/bscPlugin/CallExpressionInfo.ts. This file correctly checks for nullishness and so contains no errors, but the type signatures weren't fully specific and I changed them while debugging. I can back out these changes if so desired.

I also added | undefined to a few signatures for cases where a value may be undefined. I find this to be helpful even with strict null checks turned off, but I also can tell that it's unidiomatic for this codebase so I can remove these additional annotations if you'd prefer the change without them.

[TwitchBronBron]

Looks pretty good! One small suggestion, but otherwise I'm happy with all of these changes. Thanks for the great explanation.

[TwitchBronBron]

Can you change this to point to the actual logger file? Sometimes importing ../.. causes circular references.

[josephjunker]

Fixed!