Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(components): Implemented missing ifEnum methods in roArray and roAssociativeArray #33

Merged
merged 4 commits into from Dec 1, 2023
Merged

feat(components): Implemented missing ifEnum methods in roArray and roAssociativeArray #33

merged 4 commits into from Dec 1, 2023

Conversation

lvcabral
Copy link
Collaborator

@lvcabral lvcabral commented Nov 28, 2023 •
edited

This PR implements:

  • Methods from ifEnum: isNext(), next(), reset() (array and AA)
  • Methods from ifArrayGet/Set: getEntry(), setEntry() (array)
  • Sort AA items when printing the object (same behavior as Roku)
  • Unit Tests

TwitchBronBron
TwitchBronBron approved these changes Dec 1, 2023
View reviewed changes
Copy link
Member

@TwitchBronBron TwitchBronBron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I appreciate your comments throughout the code. it's not too chatty, but it helps explain the important bits.

@TwitchBronBron TwitchBronBron merged commit 6e5b422 into master Dec 1, 2023
2 checks passed
@TwitchBronBron TwitchBronBron deleted the implement-ifEnum-methods-roArray-roAssociativeArray branch December 1, 2023 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TwitchBronBron TwitchBronBron TwitchBronBron approved these changes

@chrisdp chrisdp Awaiting requested review from chrisdp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lvcabral @TwitchBronBron