feat(lex,parse): Add stub try/catch implementation #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RBI 9.4 adds support for error handling via the `try`/`catch` model [1]. Interestingly, `try`, `catch`, and `endtry` are all valid identifiers! That makes parsing a little bit tougher, but it's not unprecedented in this language. Detect `try`/`catch`/throw`/`end try` during lexing and emit the proper lexemes. [1] https://developer.roku.com/docs/references/brightscript/language/error-handling.html see sjbarag#554
Throwing exceptions and catching them aren't yet supported in `brs`, so executing only the `try` block seems to be a reasonable "bare minimum" approach to try/catch support. Handle `try`, `catch`, and `end try` lexemes in the parser, emitting TryCatch statements for the interpreter to execute naïvely. see sjbarag#554
TwitchBronBron
approved these changes
Dec 1, 2023
There was a problem hiding this comment.
Everything looks great here too. I remember seeing most of this when we added try/catch support to brighterscript. I did add one comment about the de-indenting logic, but not gonna hold up the PR for it. I'll merge it, and you can decide if it matters or not for some future PR.
| * @param {string} str - the string to unindent | ||
| * @return {string} `str`, but reformatted so that at least one line starts at column 0 | ||
| */ | ||
| exports.deindent = function deindent(str) { |
There was a problem hiding this comment.
Not gonna hold up the PR for this, but you could consider using undent which is a project I wrote to do exactly this. it also supports tagged template literals so you can use it like:
console.log(undent`
something
somethingElse
someThirdLine
`);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From sjbarag#611
Here's the feature working in action: