-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid false positive for missing return #78
Avoid false positive for missing return #78
Conversation
This also upgrades the Brighterscript dependency to |
60ac7a5
to
75ec235
Compare
Seems like some tests are failing in CI with the 0.59.0 upgrade, I'll fix those asap 👍 |
Thanks, the |
75ec235
to
f8216d9
Compare
Can you check if it fixes #68 |
No it doesn't but I'll add that to my PR |
63268da
to
2f66a45
Compare
Code looks good, but needs testing at scale. |
I can test this on our app today. |
Sorry for the delay. I finally got around to testing this, and it looks like it works well against our larger project! The only change I would suggest is bumping the |
Given a function with
throw
statements in some branches, there is a false positive that considers those branches as invalid. Athrow
can be a valid exit strategy for a function when "something truly terrible happens".