Fix "continue" repeat bug in protocol adapter #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a bug in the 11.5 Roku OS firmware, breakpoints created via the
ADD_CONDITIONAL_BREAKPOINTSwould hit multiple times when pressing "continue". This PR changes the logic to only useADD_CONDITIONAL_BREAKPOINTSfor breakpoints that have conditional expressions. All other breakpoints will be sent using the standardADD_BREAKPOINTSrequest instead. This means you only pay the "continue" penalty for conditional breakpoints.Also fixed an issue with sending breakpoints to the device while running.