Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds device query info to debug session #130

Merged
merged 7 commits into from
Apr 25, 2023
Merged

Conversation

sethmaclean
Copy link
Collaborator

This pull request offers changes for Fixes #121

Copy link
Member

@TwitchBronBron TwitchBronBron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good. just a few small changes.

src/debugSession/BrightScriptDebugSession.ts Outdated Show resolved Hide resolved
src/debugSession/BrightScriptDebugSession.ts Outdated Show resolved Hide resolved
@TwitchBronBron TwitchBronBron added the create-vsix PRs with this tag will trigger a vsix build on vscode-brightscript-language for every push label Jan 20, 2023
@rokucommunity-bot
Copy link

Hey there! I just built a new version of the vscode extension based on 29e2439. You can download the .vsix here and then follow these installation instructions.

src/DeviceInfo.ts Outdated Show resolved Hide resolved
TwitchBronBron and others added 2 commits April 25, 2023 10:59
Co-authored-by: Milap Naik <milapnaik@gmail.com>
@rokucommunity-bot
Copy link

Hey there! I just built a new version of the vscode extension based on 0f63b16. You can download the .vsix here and then follow these installation instructions.

@rokucommunity-bot
Copy link

Hey there! I just built a new version of the vscode extension based on 0682d93. You can download the .vsix here and then follow these installation instructions.

@TwitchBronBron TwitchBronBron merged commit 69c70cb into master Apr 25, 2023
9 checks passed
@TwitchBronBron TwitchBronBron deleted the device-info-query branch April 25, 2023 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
create-vsix PRs with this tag will trigger a vsix build on vscode-brightscript-language for every push
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do device-info query at start of debug session
3 participants