Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close debug session on home button press #166

Merged
merged 1 commit into from Oct 24, 2023

Conversation

TwitchBronBron
Copy link
Member

Fixes #165

The issue was that even if the control socket closed, we were still trying to send the "Exit channel" request, which would never go through because.....the control socket is already closed. So now we bypass that call if the control socket is already closed.

@TwitchBronBron TwitchBronBron merged commit ec08ff2 into master Oct 24, 2023
4 checks passed
@TwitchBronBron TwitchBronBron deleted the better-debugger-disconnect branch October 24, 2023 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pressing home during debug protocol session doesn't close the session
1 participant