Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug with compile error reporting #174

Merged
merged 1 commit into from Nov 16, 2023
Merged

Fix bug with compile error reporting #174

merged 1 commit into from Nov 16, 2023

Conversation

TwitchBronBron
Copy link
Member

Fix an issue where compile errors would be encountered, but we don't have a connection to the debug protocol so they were never reported. This fixes it in two ways:

  • always scrape telnet output for compile errors (even when debug protocol is enabled)
  • when showing the compile error "exception" hack, don't wait for the adapter to resolve (because it might ever resolve)

@TwitchBronBron TwitchBronBron added the create-vsix PRs with this tag will trigger a vsix build on vscode-brightscript-language for every push label Nov 16, 2023
@rokucommunity-bot
Copy link

Hey there! I just built a new version of the vscode extension based on 82fdb5b. You can download the .vsix here and then follow these installation instructions.

@TwitchBronBron TwitchBronBron merged commit 096fb60 into master Nov 16, 2023
5 checks passed
@TwitchBronBron TwitchBronBron deleted the better-compile-error-handling branch November 16, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
create-vsix PRs with this tag will trigger a vsix build on vscode-brightscript-language for every push
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@TwitchBronBron