Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add device view with direct node selection #465

Merged
merged 24 commits into from
Mar 10, 2023
Merged

Add device view with direct node selection #465

merged 24 commits into from
Mar 10, 2023

Conversation

triwav
Copy link
Collaborator

@triwav triwav commented Feb 21, 2023

No description provided.

Brian Leighty added 8 commits December 27, 2022 13:11
…d direct node selection, Add RtaManager and WebviewProviderManager to assist in interwebview communication, switch to pulling odcCommands list from requestTypes.schema.json, standardize naming of messages to either `command` or `event`, switch from using `handle` to `on` in event observers
@triwav triwav marked this pull request as draft February 21, 2023 21:28
@triwav triwav marked this pull request as ready for review February 21, 2023 22:07
@triwav triwav added the create-vsix PRs with this tag will trigger a vsix build on vscode-brightscript-language for every push label Feb 21, 2023
@rokucommunity-bot
Copy link

Hey there! I just built a new version of the vscode extension based on c935947. You can downloaded the .vsix here and then follow these installation instructions.

@triwav triwav changed the title Add device view Add device view with direct node selection Feb 21, 2023
@rokucommunity-bot
Copy link

Hey there! I just built a new version of the vscode extension based on 7cf3a66. You can downloaded the .vsix here and then follow these installation instructions.

@rokucommunity-bot
Copy link

Hey there! I just built a new version of the vscode extension based on 9a7371d. You can downloaded the .vsix here and then follow these installation instructions.

@rokucommunity-bot
Copy link

Hey there! I just built a new version of the vscode extension based on 4f924bf. You can downloaded the .vsix here and then follow these installation instructions.

this.lastStoreNodesResponse = await rta.odc.storeNodeReferences(args, options);

const viewIds = [];
if (requestorId === 'rokuDeviceView') {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a enum with panel ids

viewIds.push('rokuDeviceView');
}
this.webviewViewProviderManager.sendMessageToWebviews(viewIds, {
event: 'storedNodeReferencesUpdated'
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try to make these an enum as well

Copy link
Member

@TwitchBronBron TwitchBronBron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We reviewed this together on a video call, and it looks great!

@rokucommunity-bot
Copy link

Hey there! I just built a new version of the vscode extension based on 10aeac4. You can downloaded the .vsix here and then follow these installation instructions.

@rokucommunity-bot
Copy link

Hey there! I just built a new version of the vscode extension based on 092b89a. You can downloaded the .vsix here and then follow these installation instructions.

@rokucommunity-bot
Copy link

Hey there! I just built a new version of the vscode extension based on 178f471. You can downloaded the .vsix here and then follow these installation instructions.

@rokucommunity-bot
Copy link

Hey there! I just built a new version of the vscode extension based on 64eef27. You can downloaded the .vsix here and then follow these installation instructions.

@rokucommunity-bot
Copy link

Hey there! I just built a new version of the vscode extension based on d784733. You can downloaded the .vsix here and then follow these installation instructions.

@rokucommunity-bot
Copy link

Hey there! I just built a new version of the vscode extension based on 4d0188a. You can downloaded the .vsix here and then follow these installation instructions.

@rokucommunity-bot
Copy link

Hey there! I just built a new version of the vscode extension based on bd821f8. You can downloaded the .vsix here and then follow these installation instructions.

@rokucommunity-bot
Copy link

Hey there! I just built a new version of the vscode extension based on da5f06e. You can downloaded the .vsix here and then follow these installation instructions.

@rokucommunity-bot
Copy link

Hey there! I just built a new version of the vscode extension based on a6efbaf. You can downloaded the .vsix here and then follow these installation instructions.

@triwav triwav merged commit 597ccdd into master Mar 10, 2023
@triwav triwav deleted the add_device_view branch March 10, 2023 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
create-vsix PRs with this tag will trigger a vsix build on vscode-brightscript-language for every push
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants