-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add device view with direct node selection #465
Conversation
…nd use `#` before findNode keys
…d direct node selection, Add RtaManager and WebviewProviderManager to assist in interwebview communication, switch to pulling odcCommands list from requestTypes.schema.json, standardize naming of messages to either `command` or `event`, switch from using `handle` to `on` in event observers
Hey there! I just built a new version of the vscode extension based on c935947. You can downloaded the .vsix here and then follow these installation instructions. |
Hey there! I just built a new version of the vscode extension based on 7cf3a66. You can downloaded the .vsix here and then follow these installation instructions. |
Hey there! I just built a new version of the vscode extension based on 9a7371d. You can downloaded the .vsix here and then follow these installation instructions. |
…ther to setup watcher
Hey there! I just built a new version of the vscode extension based on 4f924bf. You can downloaded the .vsix here and then follow these installation instructions. |
src/managers/RtaManager.ts
Outdated
this.lastStoreNodesResponse = await rta.odc.storeNodeReferences(args, options); | ||
|
||
const viewIds = []; | ||
if (requestorId === 'rokuDeviceView') { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a enum with panel ids
src/managers/RtaManager.ts
Outdated
viewIds.push('rokuDeviceView'); | ||
} | ||
this.webviewViewProviderManager.sendMessageToWebviews(viewIds, { | ||
event: 'storedNodeReferencesUpdated' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Try to make these an enum as well
webviews/src/views/SceneGraphInspectorView/NodeBranchPage.svelte
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We reviewed this together on a video call, and it looks great!
Hey there! I just built a new version of the vscode extension based on 10aeac4. You can downloaded the .vsix here and then follow these installation instructions. |
Hey there! I just built a new version of the vscode extension based on 092b89a. You can downloaded the .vsix here and then follow these installation instructions. |
Hey there! I just built a new version of the vscode extension based on 178f471. You can downloaded the .vsix here and then follow these installation instructions. |
Hey there! I just built a new version of the vscode extension based on 64eef27. You can downloaded the .vsix here and then follow these installation instructions. |
Hey there! I just built a new version of the vscode extension based on d784733. You can downloaded the .vsix here and then follow these installation instructions. |
…oviderCommand and VscodeCommand enums
Hey there! I just built a new version of the vscode extension based on 4d0188a. You can downloaded the .vsix here and then follow these installation instructions. |
Hey there! I just built a new version of the vscode extension based on bd821f8. You can downloaded the .vsix here and then follow these installation instructions. |
Hey there! I just built a new version of the vscode extension based on da5f06e. You can downloaded the .vsix here and then follow these installation instructions. |
Hey there! I just built a new version of the vscode extension based on a6efbaf. You can downloaded the .vsix here and then follow these installation instructions. |
No description provided.