Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance host picker during launch #512

Merged
merged 7 commits into from Oct 31, 2023
Merged

Conversation

TwitchBronBron
Copy link
Member

@TwitchBronBron TwitchBronBron commented Oct 30, 2023

Adds several improvements to the "${promptForHost}" option when launching:

  • add last used separator for the last used device
  • add devices/other devices for devices not last used
  • add separator line to separate the enter manually option
  • refresh the list any time a new device is discovered, instead of a blanket "wait 5 seconds" that was there previously
  • show a loader when we think there are more devices to be discovered

Here's a preview of the feature:

loading-picker

@TwitchBronBron TwitchBronBron merged commit bfa161c into master Oct 31, 2023
5 checks passed
@TwitchBronBron TwitchBronBron deleted the enhance-device-picker branch October 31, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant